[SPH] give the option to print CFL calculation detail (e.g. per CFL prints)#1888
Merged
Conversation
Contributor
|
Thanks @tdavidcl for opening this PR! You can do multiple things directly here: Once the workflow completes a message will appear displaying informations related to the run. Also the PR gets automatically reviewed by gemini, you can: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the CFL timestep calculation in the SPH solver into separate modular nodes (ComputeCFL_Courant, ComputeCFL_Force, and ComputeCFL_DivB_Cleaning) and introduces a configuration option show_cfl_detail to log a detailed breakdown of the different CFL contributions. However, a critical bug was identified: when show_cfl_detail is disabled, the dt_part field is never updated with the calculated SPH timesteps, leaving it filled with infinity. A suggestion is provided to ensure save_dt_min_to_dt_part() is called even when detailed logging is disabled.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
Workflow reportworkflow report corresponding to commit 15d9239 Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportDoxygen diff with
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a show_cfl_detail configuration option to output detailed CFL timestep information, refactoring the CFL calculations in Solver.cpp into dedicated solver graph nodes (ComputeCFL_Courant, ComputeCFL_Force, and ComputeCFL_DivB_Cleaning). The review feedback highlights critical division-by-zero risks in these new nodes when vsig_a, abs_a_a, or vclean_a are zero, and suggests adding guards to prevent NaNs or infinities from crashing the simulation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.