[ExtForces] Add pseudo-Newtonian Paczynsky-Witta potential#1882
Open
y-lapeyre wants to merge 4 commits into
Open
[ExtForces] Add pseudo-Newtonian Paczynsky-Witta potential#1882y-lapeyre wants to merge 4 commits into
y-lapeyre wants to merge 4 commits into
Conversation
y-lapeyre
commented
Jun 21, 2026
y-lapeyre
commented
Collaborator
- check it on test problem
Contributor
|
Thanks @y-lapeyre for opening this PR! You can do multiple things directly here: Once the workflow completes a message will appear displaying informations related to the run. Also the PR gets automatically reviewed by gemini, you can: |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new pseudo-Newtonian Paczynsky-Witta (1980) external force potential (AddForcePaczynskyWitta), integrating it into the CMake build, configuration structures, serialization, and Python bindings. The review feedback highlights critical mathematical and performance issues in the acceleration calculation, such as an incorrect sign for the Schwarzschild radius, an incorrect denominator, and loop-invariant computations inside the kernel. Additionally, the new force variant is unhandled in add_ext_forces() and point_mass_accrete_particles(), which would cause runtime crashes and prevent particle accretion. Finally, the LaTeX formula in the documentation needs to be corrected to accurately reflect the potential.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
tdavidcl
reviewed
Jun 21, 2026
Contributor
Workflow reportworkflow report corresponding to commit 121ee24 Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Clang-tidy diff reportDoxygen diff with
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.