fix(scan): drop node uptime from the live ticker#109
Conversation
uptime_seconds is the serving node's process uptime since its last restart, not chain or network uptime, and no major explorer surfaces it (Etherscan, Solscan show price/market/tx/block stats, validator uptime lives on the validators page). On a restart-heavy testnet it just looked wrong. Removed the ticker item and the now-unused status prop and useChainStatus wiring.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughHomeContent no longer imports or calls Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: private package registry requires authentication. Disable ESLint in CodeRabbit settings or use public packages. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Follow-up to #108. The ticker's uptime stat was uptime_seconds from /sentrix_status, which is the serving node's process uptime since its last restart, not chain/network uptime. No major explorer shows this (Etherscan and Solscan home stats are price/market cap/transactions/gas/block; validator uptime % lives on a validators page). On a restart-heavy testnet it kept reading as wrong. Removed the item and cleaned up the now-unused status prop on LiveTicker and the useChainStatus hook in HomeContent. The other nine ticker stats are unchanged. Verified live: no uptime entry remains.
Testing: typecheck and build pass.
Summary by CodeRabbit