Bug/sc 39280/ library notes preexisting pre mdl notes on a #2926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ria-Project into modularization-main
…reexisting-pre-mdl-notes-on-a
YishaiGlasner
requested changes
Dec 28, 2025
static/js/NoteListing.jsx
Outdated
Comment on lines
40
to
51
| let path, noteURL; | ||
| const module = isSheet ? Sefaria.VOICES_MODULE : Sefaria.LIBRARY_MODULE; | ||
| if (isSheet) { | ||
| const parsedRef = Sefaria.parseRef(ref); | ||
| path = `/sheets/${parsedRef.sections.join('.')}`; | ||
| noteURL = new URL(path, Sefaria.getModuleURL(module)); | ||
| } | ||
| else { | ||
| path = `/${ref}`; | ||
| noteURL = new URL(path, Sefaria.getModuleURL(module)); | ||
| noteURL.searchParams.set('with', 'Notes'); // side panel should only open to show notes in Library module | ||
| } |
Contributor
There was a problem hiding this comment.
you can insert the module into the if-else blocks to avoid checking isSheet twice.
it still will have noteURL = new URL(path, Sefaria.getModuleURL(module)); twich which i really don't like, but i didn't find the right way to do it. it's worth to give it another think. maybe some of the logic here can be generalized to a separate helper function in Sefaria.
Contributor
Author
There was a problem hiding this comment.
OK I just pushed again. Let me know what you think of my re-factor. I used a helper function we already had with some changes.
…reexisting-pre-mdl-notes-on-a
stevekaplan123
changed the base branch from
modularization-main
to
modularization-future
Co-authored-by: YishaiGlasner <60393023+YishaiGlasner@users.noreply.github.com>
Co-authored-by: YishaiGlasner <60393023+YishaiGlasner@users.noreply.github.com>
YishaiGlasner
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If there is a note on a sheet, link it to voices module. The previous functionality was actually wrong. I've now added a function
getNoteURLbecause the behavior is quite different. This comment explains:// This helper function returns the a tag linking to the given ref of the note When the URL is to a ref in the library,
// returning the appropriate a tag is very simple, but when the ref is to a sheet, we need to modify the ref and set the data-target-module attribute to the voices module.
// If the ref is to a sheet, the ref will be something like "Sheet 3.4" but it needs to link to "/sheets/3.4" in the voices module.