feat: Enhance l10n error handling by introducing seedsigner_gettext#910
Open
S1DDHEY wants to merge 2 commits intoSeedSigner:devfrom
Open
feat: Enhance l10n error handling by introducing seedsigner_gettext#910S1DDHEY wants to merge 2 commits intoSeedSigner:devfrom
S1DDHEY wants to merge 2 commits intoSeedSigner:devfrom
Conversation
…sages Signed-off-by: AdityaPandeyCN <adityapand3y666@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem or Issue being addressed
PR #702 (by @AdityaPandeyCN) introduced
seedsigner_gettextandseedsigner_ngettext, enhanced gettext wrappers that catch formatting errors in translations (e.g.,{}instead of{variable_name}) and raise a descriptiveTranslationVariableMissingError.That PR currently has no test coverage.
Solution
Added comprehensive
pytesttest coverage for the enhanced gettext functionality intests/test_l10n_gettext.py(36 tests)Additional Information
gettext.gettext/gettext.ngettext, no dependency on real.po/.mofilesSettingsto avoid hardware/filesystem dependencies.pofile (replacing{mnemonic_length}and{num_bits}with positional{}), followed by recompilinggettextwith more robust error handling #693Screenshots
Emulator error screen triggered by intentionally corrupted German translation:
This pull request is categorized as a:
Checklist
I ran
pytestlocallyI included screenshots of any new or modified screens
Should be part of the PR description above.
I added or updated tests
Any new or altered functionality should be covered in a unit test. Any new or updated sequences require FlowTests.
I tested this PR hands-on on the following platform(s):
I have reviewed these notes:
Thank you! Please join our Devs' Telegram group to get more involved.