Skip to content

feat: Enhance l10n error handling by introducing seedsigner_gettext#910

Open
S1DDHEY wants to merge 2 commits intoSeedSigner:devfrom
S1DDHEY:enhance-l10n-error-handling
Open

feat: Enhance l10n error handling by introducing seedsigner_gettext#910
S1DDHEY wants to merge 2 commits intoSeedSigner:devfrom
S1DDHEY:enhance-l10n-error-handling

Conversation

@S1DDHEY
Copy link
Copy Markdown

@S1DDHEY S1DDHEY commented Apr 9, 2026

Description

Problem or Issue being addressed

PR #702 (by @AdityaPandeyCN) introduced seedsigner_gettext and seedsigner_ngettext, enhanced gettext wrappers that catch formatting errors in translations (e.g., {} instead of {variable_name}) and raise a descriptive TranslationVariableMissingError.
That PR currently has no test coverage.

Solution

Added comprehensive pytest test coverage for the enhanced gettext functionality in tests/test_l10n_gettext.py (36 tests)

Additional Information

Screenshots

Emulator error screen triggered by intentionally corrupted German translation:

Screenshot from 2026-04-10 02-55-50

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Documentation
  • Other

Checklist

I ran pytest locally

  • All tests passed before submitting the PR
  • I couldn't run the tests
  • N/A

I included screenshots of any new or modified screens

Should be part of the PR description above.

  • Yes
  • No
  • N/A

I added or updated tests

Any new or altered functionality should be covered in a unit test. Any new or updated sequences require FlowTests.

  • Yes
  • No, I’m a fool
  • N/A

I tested this PR hands-on on the following platform(s):


I have reviewed these notes:

  • Keep your changes limited in scope.
  • If you uncover other issues or improvements along the way, ideally submit those as a separate PR.
  • The more complicated the PR, the harder it is to review, test, and merge.
  • We appreciate your efforts, but we're a small team of volunteers so PR review can be a very slow process.
  • Please only "@" mention a contributor if their input is truly needed to enable further progress.
  • I understand

Thank you! Please join our Devs' Telegram group to get more involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants