[Bugfix] Back Navigation in Seed Entry Views#900
[Bugfix] Back Navigation in Seed Entry Views#900PROWLERx15 wants to merge 4 commits intoSeedSigner:devfrom
Conversation
Chaitanya-Keyal
left a comment
There was a problem hiding this comment.
Thanks for the PR, this is a great catch!
However, I was unable to reproduce the issue you mention with SeedFinalizeView; the back button is explicitly disabled for SeedFinalizeScreen, so RET_CODE__BACK_BUTTON should not be reachable there in normal flow:
Given that, I think we should rather just remove the back button elif branch in SeedFinalizeView (and any test that relies on that unreachable path), and keep the mnemonic-entry fix/tests which address the real issue.
If you can share a concrete repro path or traceback for the finalize crash, happy to take another look.
You're right, the back button is disabled on |
Description
Problem or Issue being addressed
Pressing BACK on the first word of seed entry takes you straight to the Main Menu instead of going back to the Seeds Menu where you came from.
Current behavior:
Seeds Menu → Enter 12-word seed → Back → Main Menu
Seeds Menu → Enter 24-word seed → Back → Main Menu
Expected behavior:
Seeds Menu → Enter 12-word seed → Back → Seeds Menu
Seeds Menu → Enter 24-word seed → Back → Seeds Menu
Solution
SeedMnemonicEntryView: When pressing BACK on the first word, the old code hard-coded a jump toMainMenuView. Changed it to useBackStackViewinstead, so it naturally returns to wherever the user came from, eitherLoadSeedView(the normal "enter a seed" path) orSeedSelectSeedView(when entering a seed mid-flow, like during sign message).The pending mnemonic is still properly discarded.
Additional Information
Screenshots
No UI changes, only navigation logic.
This pull request is categorized as a:
Checklist
I ran
pytestlocallyI included screenshots of any new or modified screens
Should be part of the PR description above.
I added or updated tests
Any new or altered functionality should be covered in a unit test. Any new or updated sequences require FlowTests.
I tested this PR hands-on on the following platform(s):
I have reviewed these notes:
Thank you! Please join our Devs' Telegram group to get more involved.