ci: add screenshot gallery GitHub Pages deploy#894
Open
Krupakar-Reddy-S wants to merge 1 commit intoSeedSigner:devfrom
Open
ci: add screenshot gallery GitHub Pages deploy#894Krupakar-Reddy-S wants to merge 1 commit intoSeedSigner:devfrom
Krupakar-Reddy-S wants to merge 1 commit intoSeedSigner:devfrom
Conversation
|
Nice improvement overall. One optional enhancement: can we add SeedSigner branding (logo/header styling) to the generated Pages site so it feels consistent with the main website? Deferring to maintainers on product value and prioritisation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem or Issue being addressed
The screenshot generator (
tests/screenshot_generator/generator.py) already renders all views for every detected locale and produces gallery READMEs with translation completion percentages. CI runs it on every push and saves the output as artifacts. But there's no public-facing gallery — translators on Transifex can't see their work rendered visually.Solution
Adds a new workflow (
.github/workflows/screenshots.yml) that:devREADME.mdtoindex.mdand fixes internal links for clean directory URLsactions/jekyll-build-pages(renders markdown + images)actions/deploy-pagesThe index page lists all detected locales with links to per-locale galleries. Each locale gallery shows translation completion percentage and all screenshot sections (Main Menu, Seed, PSBT, Tools, Settings, Misc Error views).
Additional Information
https://seedsigner.github.io/seedsigner/tests.yml— keeps deploy logic isolated and only triggers ondevpushes, not PRs.Screenshots
This pull request is categorized as a:
Checklist
I ran
pytestlocallyI included screenshots of any new or modified screens
Should be part of the PR description above.
I added or updated tests
Any new or altered functionality should be covered in a unit test. Any new or updated sequences require FlowTests.
I tested this PR hands-on on the following platform(s):
I have reviewed these notes:
Thank you! Please join our Devs' Telegram group to get more involved.