Skip to content

ADD: BIP47 (m/47') derivation path support for message signing #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MightyMercurian wants to merge 1 commit into
base: dev
Choose a base branch
from
+28 −0
Open

ADD: BIP47 (m/47') derivation path support for message signing #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/seedsigner/helpers/embit_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ def parse_derivation_path(derivation_path: str) -> dict:
lookups = {
"script_types": {
"44h": SettingsConstants.LEGACY_P2PKH,
"47h": SettingsConstants.LEGACY_P2PKH,
"49h": SettingsConstants.NESTED_SEGWIT,
"84h": SettingsConstants.NATIVE_SEGWIT,
"86h": SettingsConstants.TAPROOT,
Expand Down
27 changes: 27 additions & 0 deletions tests/test_flows_seed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,7 @@ def test_transcribe_seedqr_screensaver_startable_status(self):
class TestMessageSigningFlows(FlowTest):
MAINNET_DERIVATION_PATH = "m/84h/0h/0h/0/0"
TESTNET_DERIVATION_PATH = "m/84h/1h/0h/0/0"
BIP47_DERIVATION_PATH = "m/47h/0h/0h/0/0"
CUSTOM_DERIVATION_PATH = "m/99h/0/0"
SHORT_MESSAGE = "I attest that I control this bitcoin address blah blah blah"
NO_WHITESPACE_MESSAGE = """{"height":841407,"lightning_bolt12":"lno1xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"}"""
Expand Down Expand Up @@ -534,6 +535,10 @@ def load_no_whitespace_message_into_decoder(self, view: View):
self.load_signmessage_into_decoder(view, self.MAINNET_DERIVATION_PATH, self.NO_WHITESPACE_MESSAGE)


def load_bip47_message_into_decoder(self, view: View):
self.load_signmessage_into_decoder(view, self.BIP47_DERIVATION_PATH, self.SHORT_MESSAGE)


def load_custom_derivation_into_decoder(self, view: View):
self.load_signmessage_into_decoder(view, self.CUSTOM_DERIVATION_PATH, self.SHORT_MESSAGE)

Expand Down Expand Up @@ -636,6 +641,28 @@ def test_sign_message_flow(self):
])


def test_sign_message_bip47_flow(self):
"""
Should sign a message using a BIP47 derivation path (m/47h/0h/0h/0/0).
This enables Auth47 challenge signing and PayNym claim signing.
"""
self.settings.set_value(SettingsConstants.SETTING__MESSAGE_SIGNING, SettingsConstants.OPTION__ENABLED)

self.run_sequence([
FlowStep(MainMenuView, button_data_selection=MainMenuView.SCAN),
FlowStep(scan_views.ScanView, before_run=self.load_bip47_message_into_decoder),
FlowStep(seed_views.SeedSignMessageStartView, is_redirect=True),
FlowStep(seed_views.SeedSelectSeedView, button_data_selection=seed_views.SeedSelectSeedView.SCAN_SEED),
FlowStep(scan_views.ScanView, before_run=self.load_seed_into_decoder),
FlowStep(seed_views.SeedFinalizeView, button_data_selection=seed_views.SeedFinalizeView.FINALIZE),
FlowStep(seed_views.SeedOptionsView, is_redirect=True),
FlowStep(seed_views.SeedSignMessageConfirmMessageView, before_run=self.inject_mesage_as_paged_message, screen_return_value=0),
FlowStep(seed_views.SeedSignMessageConfirmAddressView, screen_return_value=0),
FlowStep(seed_views.SeedSignMessageSignedMessageQRView, screen_return_value=0),
FlowStep(MainMenuView),
])


def test_sign_message_network_mismatch_flow(self):
"""
Should redirect to NetworkMismatchErrorView if a message's derivation path network doesn't match the current network.
Expand Down