Skip to content

[l10n] Finalize v0.8.7 languages#889

Merged
newtonick merged 2 commits intoSeedSigner:devfrom
kdmukai:2026-03-06_finalize_languages_v0_8_7
Mar 12, 2026
Merged

[l10n] Finalize v0.8.7 languages#889
newtonick merged 2 commits intoSeedSigner:devfrom
kdmukai:2026-03-06_finalize_languages_v0_8_7

Conversation

@kdmukai
Copy link
Copy Markdown
Contributor

@kdmukai kdmukai commented Mar 6, 2026

Description

Activates the list of languages for v0.8.7.

Verified that the screenshot generator produces screenshots for each activated language when their .po and .mo files are available to the local system.

The new languages each require a new PR in the translations repo. If translation files are not detected for a given language, it will not appear in the language selection list in the UI.


This pull request is categorized as a:

  • New feature

Checklist

I ran pytest locally

  • All tests passed before submitting the PR

I included screenshots of any new or modified screens

Should be part of the PR description above.

  • N/A

I added or updated tests

Any new or altered functionality should be covered in a unit test. Any new or updated sequences require FlowTests.

  • N/A

I tested this PR hands-on on the following platform(s):


I have reviewed these notes:

  • Keep your changes limited in scope.
  • If you uncover other issues or improvements along the way, ideally submit those as a separate PR.
  • The more complicated the PR, the harder it is to review, test, and merge.
  • We appreciate your efforts, but we're a small team of volunteers so PR review can be a very slow process.
  • Please only "@" mention a contributor if their input is truly needed to enable further progress.
  • I understand

Copy link
Copy Markdown
Contributor

@Chaitanya-Keyal Chaitanya-Keyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

Do you think it might be worth it to break this dict down into separate smaller dicts for each "type" of language we have?

For example, fully_supported, beta, in_progress, and then these could be merged into one consolidated list where the "beta" and "incomplete" labels are added programmatically.

@newtonick
Copy link
Copy Markdown
Collaborator

newtonick commented Mar 7, 2026

When I run the screenshot generator on Farsi (fa) it fails. This is the only language that failed.

I gave Claude the output of the pytest tests/screenshot_generator/generator.py command and this is what it told me:

The Farsi (fa) translation for the string at src/seedsigner/gui/screens/tools_screens.py:214 contains a positional placeholder like {0} instead of the named placeholders {mnemonic_length}
and {num_bits}.

The source string is:
"The {mnemonic_length}th word is built from {num_bits} more entropy bits plus auto-calculated checksum."

When .format(mnemonic_length=..., num_bits=...) is called, it uses keyword arguments. If the Farsi translation has positional placeholders (e.g. {0}, {1}) instead of {mnemonic_length} and
{num_bits}, it throws IndexError: Replacement index 0 out of range for positional args tuple.

This is a bug in the Farsi translation in the seedsigner-translations submodule — the translator likely used {0} and {1} instead of {mnemonic_length} and {num_bits}. The fix needs to happen
in the fa locale's messages.po file.

I didn't dig any further.

@Chaitanya-Keyal
Copy link
Copy Markdown
Contributor

@newtonick Is it possible your local messages.po/messages.mo is invalid for farsi?

I ran the screenshot generator both with and without the latest translation from the farsi PR, and did not see any errors.

Moreover, this PR just simply reorders keys and renames some values in a dict, it shouldn't affect anything else.

@newtonick
Copy link
Copy Markdown
Collaborator

ACK

@newtonick newtonick merged commit 2c486eb into SeedSigner:dev Mar 12, 2026
2 checks passed
@newtonick newtonick moved this from 0.8.7 Needs Code Review to 0.8.7 Merged in @SeedSigner Development Board Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 0.8.7 Merged

Development

Successfully merging this pull request may close these issues.

3 participants