[Feature] Enable build via Podman and Docker#107
Draft
newtonick wants to merge 1 commit intoSeedSigner:mainfrom
Draft
[Feature] Enable build via Podman and Docker#107newtonick wants to merge 1 commit intoSeedSigner:mainfrom
newtonick wants to merge 1 commit intoSeedSigner:mainfrom
Conversation
…both docker and podman.
4c4f818 to
c3cf4e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is Podman? A: Its a free & open source container tool that can be used in place of Docker.
This minor change is to make small changes to the
Dockerfileanddocker-compose.ymlfile to allow the build to work for both Docker and Podman. Podman still uses theDockerfileanddocker-compose.ymlfor build config.Dockerfile change:
Updating the entry point to
ENTRYPOINT ["/bin/bash", "-c", "./build.sh $SS_ARGS"]fromENTRYPOINT ["./build.sh"]. This new entrypoint wraps the build script in/bin/bash -c, which invokes a shell that expands$SS_ARGSbefore passing the arguments tobuild.sh. This allows moving the $SS_ARGS command as an environment variable instead of a command.The docker-compose.yml change:
Shifts how build arguments are passed from a command override to an environment variable. Before: SS_ARGS was expanded on the host side by docker-compose and passed as a command argument, which overrides the container's ENTRYPOINT arguments. This worked with the old ENTRYPOINT ["./build.sh"] since Docker appends command values as arguments to the entrypoint. After: SS_ARGS is passed into the container as an environment variable. The updated ENTRYPOINT (/bin/bash -c "./build.sh $SS_ARGS") then expands it inside the container at runtime.
The default value ${SS_ARGS:---no-op} is preserved — if you don't set SS_ARGS on the host, it defaults to --no-op, which starts the container without running a build (useful for the interactive dev workflow where you docker exec in and run builds manually).
Reproducible build steps with Podman on a mac:
Equivalent Docker command (skipping install steps):