Skip to content

Conversation

@iceljc
Copy link
Collaborator

@iceljc iceljc commented Jan 7, 2026

PR Type

Bug fix


Description

  • Updated BotSharp.Plugin.MultiTenancy project GUID in solution file

  • Reorganized project references in WebStarter configuration

  • Added BotSharp.Plugin.MMPEmbedding plugin to dependencies

  • Moved BotSharp.Core.A2A reference to correct solution folder


Diagram Walkthrough

flowchart LR
  A["BotSharp.sln"] -->|"Update GUID"| B["MultiTenancy Project"]
  C["WebStarter.csproj"] -->|"Remove reference"| D["BotSharp.Core.A2A"]
  C -->|"Add reference"| E["BotSharp.Plugin.MMPEmbedding"]
  C -->|"Reorganize"| F["Project References"]
  G["appsettings.json"] -->|"Add plugin"| E
Loading

File Walkthrough

Relevant files
Configuration changes
BotSharp.sln
Update MultiTenancy project GUID and folder                           

BotSharp.sln

  • Updated BotSharp.Plugin.MultiTenancy project GUID from
    {9BC8DF43-88D1-4C57-A678-AC0153BDF4EB} to
    {562DD0C6-DAC8-02CC-C1DD-D43DF186CE76}
  • Updated all references to the old GUID in solution configuration
    sections
  • Changed MultiTenancy project folder assignment from
    {7C64208C-8D11-4E17-A3E9-14D7910763EB} to
    {51AFE054-AE99-497D-A593-69BAEFB5106F}
+10/-10 
WebStarter.csproj
Reorganize project references and add MMPEmbedding             

src/WebStarter/WebStarter.csproj

  • Removed BotSharp.Core.A2A project reference from PizzaBot solution
    configuration
  • Added BotSharp.Plugin.MMPEmbedding project reference to plugin
    dependencies
  • Moved BotSharp.Core.A2A reference to BotSharp solution configuration
    section
+2/-1     
appsettings.json
Register MMPEmbedding plugin in settings                                 

src/WebStarter/appsettings.json

  • Added BotSharp.Plugin.MMPEmbedding to the plugin list in configuration
+1/-0     

@iceljc iceljc merged commit 9764b75 into SciSharp:master Jan 7, 2026
3 of 4 checks passed
@qodo-code-review
Copy link

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Quote MSBuild Condition properly

Update the MSBuild condition to properly quote the property and string value for
comparison, enhancing robustness.

src/WebStarter/WebStarter.csproj [47]

-<ItemGroup Condition="$(SolutionName)==BotSharp">
+<ItemGroup Condition="'$(SolutionName)' == 'BotSharp'">

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 5

__

Why: The suggestion correctly identifies a more robust syntax for MSBuild conditions by quoting string literals, which is a recommended best practice, although the existing code is likely to work correctly in this specific case.

Low
  • More

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant