Allow intentional CommonSolve solve reexport in QA - #127
Merged
ChrisRackauckas merged 1 commit intoJul 22, 2026
Merged
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
Investigation scratchpad for the clean-
Final local verification on
Workspace-local raw evidence and SHA-256:
|
Member
Author
|
Post-timer CI classification at immutable head
Archived evidence:
|
ChrisRackauckas
marked this pull request as ready for review
July 22, 2026 02:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore this PR until reviewed by @ChrisRackauckas.
Summary
[:solve].Root cause
SciMLTesting 2.4.0 enabled the public re-export audit by default. FiniteVolumeMethod intentionally imports and exports CommonSolve's
solvegeneric and defines package-specific methods on it, so cleanmainbegan failing the new check even though #126 changed only the downgrade workflow.The dependency boundary was verified locally on clean merge commit
e9fdb36edcdc7a8a528d47b19aaece5f5da2427e:reexported == [:solve].Validation
GROUP=QA, SciMLTesting 2.4.0, exact hosted test arguments: QA 20/20 passed.GROUP=QA, SciMLTesting 2.4.0, exact hosted test arguments: QA 18/18 passed.--check .: exit 0.git diff --check: exit 0.The first local LTS invocation stopped before running tests because an ignored Julia 1.12 manifest from the preceding local run was still present. I removed only that generated manifest and reran from a clean resolution state; the LTS QA result above is from the clean rerun.