Simplify store operations #394
Open
+444
−228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
force-pushed
the
more_bytecode_update
branch
2 times, most recently
from
611acda to
7b8ace2
Compare
zherczeg
force-pushed
the
more_bytecode_update
branch
5 times, most recently
from
63341e8 to
628756e
Compare
zherczeg
force-pushed
the
more_bytecode_update
branch
from
628756e to
dbff2b2
Compare
Float / int load is split. Target is computed automatically for stores. The 32 / 64 bit stores use a different argument order to prevent code merging. Signed-off-by: Zoltan Herczeg [email protected]
zherczeg
force-pushed
the
more_bytecode_update
branch
from
dbff2b2 to
0bcb8db
Compare
Collaborator
Author
|
The reason I work on these dst/src swapping is that the "merging code paths" in the interpreter with computed goto is a valid compiler optimization, although no other compiler did it so far. However, it is kind of a minefield, since computed goto address to byte code index conversion is not possible, and better to fix it before other compilers start doing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically target for stores.
LoadMemIdx int/float variants gets different code paths.