build/tools/armino: newly added support for multiple types of flash#7286
Open
boyiLiuer wants to merge 1 commit intoSamsung:masterfrom
Open
build/tools/armino: newly added support for multiple types of flash#7286boyiLiuer wants to merge 1 commit intoSamsung:masterfrom
boyiLiuer wants to merge 1 commit intoSamsung:masterfrom
Conversation
Contributor
|
Is this verified? Could you add booting logs for each flash in the commit description? |
Author
We have newly added support for 5 flash models in this update.Among them, 4 have passed local verification, and the last one will be verified by our on-site team. |
boyiLiuer
force-pushed
the
support_new_flash_0416
branch
from
bb01520 to
c3aad08
Compare
Contributor
|
After apply this PR and
Hello @sunghan-chang , I have verified the 5 different flash types board (the flash id are XTX_0xb4018, Winb_0xef4018, BY_0x684018, GD_0xc84018 and XMC_0x204018) with PR7286 and PR7276. |
Taejun-Kwon
reviewed
Apr 20, 2026
Contributor
Taejun-Kwon
left a comment
Taejun-Kwon
left a comment
There was a problem hiding this comment.
can you please translate comment from chinese to english??
Contributor
|
Below is my error when I try download in ubuntu. can you please check this? |
Author
Okay, I will translate the corresponding Chinese into English. |
Author
Please kindly check if you have modified any of the files related to the download. If there are changes, could you sync the modified parts with me so I can verify locally? Thank you. |
Contributor
Download Log |
Contributor
Hello ,Mr Eom. |
Contributor
Hello, I just pulled this PR & #7276. code base is below |
boyiLiuer
force-pushed
the
support_new_flash_0416
branch
from
c3aad08 to
c359e6c
Compare
Author
I have revised the comments as requested. Thank you. |
Author
Thank you for the information; I will analyze it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the download function. The change is the addition of support for multiple types of flash.