os/board/bk7239n: Add reset RTX interface and clear regdomain when changes#7285
Open
wangyin-aclsemi wants to merge 1 commit intoSamsung:masterfrom
Open
os/board/bk7239n: Add reset RTX interface and clear regdomain when changes#7285wangyin-aclsemi wants to merge 1 commit intoSamsung:masterfrom
wangyin-aclsemi wants to merge 1 commit intoSamsung:masterfrom
Conversation
Contributor
|
The commit does not have a title. Could you follow our commit rules? |
bdd202f to
3a90875
Compare
| UINT32 tx_evm_mode_get(void); | ||
| void bk_cal_get_txpwr_tabl(uint8_t *cal_array_ptr); | ||
|
|
||
| #if CONFIG_SOC_BK7239XX |
Contributor
There was a problem hiding this comment.
How do you use the definition?
#define CONFIG_SOC_BK7239XX 1
or
#define CONFIG_SOC_BK7239XX 0
like this?
or
#define CONFIG_SOC_BK7239XX
or
// #define CONFIG_SOC_BK7239XX
like this?
Your code is valid with first example. If you define it in a defconfig and it's a bool type,
then 2nd example is right.
When I search the config, your team mix-uses it.
@Poly-J @ziliguo Could you check your another codes for this point?
Contributor
This is the commit title. But it lists the file name only. I can't get what the commit. How about this? |
Contributor
|
@wangyin-aclsemi Could you change the commit? not the PR |
Author
Title not displayed completely, modified. |
…nges Add reset RTX interface,and reset regdomain when alpha2 changes and sta disconnect. Key changes: -Add a reset RTX interface for use. -When the STA disconnects, restore the default regdomain; reset the regdomain when alpha2 changes.
3a90875 to
efec2cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add reset RTX interface,and reset regdomain when alpha2 changes and sta disconnect.
Key changes: