os: Support ss partition powercut function of bk7239n by Poly-J · Pull Request #7281 · Samsung/TizenRT

Poly-J · 2026-04-16T07:27:01Z

Based on the new partitioning, the layout of the SS partition has been readapted and the powercut function is supported.

ewoodev

please remove ss.bin in this repo

xiaotao-yuan · 2026-04-16T10:32:50Z

please remove ss.bin in this repo

hi @ewoodev ，
This ss.bin was generated based on the demo file secure_storage. csv. As the generated script is closed source, placing this file is only for testing the secure storage function.

sunghan-chang · 2026-04-16T12:15:52Z

@@ -2851,7 +2851,7 @@ int armino_hal_write_storage(uint32_t ss_idx, hal_data *data)
    TFM_NSC_UNLOCK();
    if (ret != 0) {
        dbg("Failed to write storage: %d\n", ret);


@jylee9613 Regardless of this PR, could you check se specific dbg? The dbg is only way for here?

@Poly-J , There are sedbg and selldbg. so please use them.

@pcs1265 Thank you for your feedback. I have replaced all the 'dbg' in the file with 'sedbg'.

sunghan-chang · 2026-04-17T02:24:15Z


 #define HWRAP_TAG "[ARMINO_HAL_WRAPPER]"
-#define HWRAP_ENTER do { dbg(HWRAP_TAG"%s:%d\n", __FILE__, __LINE__); } while (0)
+#define HWRAP_ENTER do { sedbg(HWRAP_TAG"%s:%d\n", __FILE__, __LINE__); } while (0)


Let's split the commit to replace dbg to sedbg. It's different topic.

xxvdbg for information, xxdbg for error. You changed all to sedbg. But many things are information. Could you use them differently?

@sunghan-chang Thank you for the reminder, I have added another commit.

sunghan-chang · 2026-04-17T05:54:43Z


    if (key_idx < FACTORY_KEY_INDEX_MAX) {
-        dbg("Key index %d (0-31)  for factory key\n", key_idx);
+        sedbg("Key index %d (0-31)  for factory key\n", key_idx);


We should not print this information. Let's use read only instead of factory

There are another locations for that. Need to modify as well.

Thank you, I have already made the changes

ewoodev · 2026-04-17T07:13:43Z

please remove ss.bin in this repo

hi @ewoodev ， This ss.bin was generated based on the demo file secure_storage. csv. As the generated script is closed source, placing this file is only for testing the secure storage function.

yes, The generated scripte is in closed source, so we don't need to open ss.bin here also. Please remove this file.

xiaotao-yuan · 2026-04-17T08:25:27Z

please remove ss.bin in this repo

hi @ewoodev ， This ss.bin was generated based on the demo file secure_storage. csv. As the generated script is closed source, placing this file is only for testing the secure storage function.

yes, The generated scripte is in closed source, so we don't need to open ss.bin here also. Please remove this file.

hi @ewoodev ，
We use ss.bin for internal testing. During compilation, when beken-utils does not exist, the file in this path is used for testing. If you feel that there is no need to place this file, we will specifically delete it in the next PR

ewoodev

build/tools/armino: Support ss partition powercut function of bk7239n

please remove this commit in this PR. and let's remove ss.bin next PR.

Change the return value of the interface so that when an error occurs, the internal error code is directly displayed, making it easier to locate the problem.

Use sedbg and sevdbg to distinguish different log information.

Since implementing the powercut function for the ss partition changed the logic in tfm, it is necessary to synchronously update the closed-source tfm library.

jylee9613

Checked it works properly with new ss.bin

ewoodev reviewed Apr 16, 2026

View reviewed changes

Comment thread os/se/armino/security_armino_wrapper_tz.c

Poly-J force-pushed the secu_dev branch from 9f091b6 to ddb7fbd Compare April 16, 2026 11:21

sunghan-chang reviewed Apr 16, 2026

View reviewed changes

Poly-J force-pushed the secu_dev branch from ddb7fbd to 9bf379c Compare April 17, 2026 02:11

sunghan-chang reviewed Apr 17, 2026

View reviewed changes

Poly-J force-pushed the secu_dev branch from 9bf379c to 5da6062 Compare April 17, 2026 02:48

sunghan-chang reviewed Apr 17, 2026

View reviewed changes

Poly-J force-pushed the secu_dev branch from 5da6062 to f9db526 Compare April 17, 2026 06:14

ewoodev previously approved these changes Apr 17, 2026

View reviewed changes

Poly-J dismissed ewoodev’s stale review via 87d3373 April 17, 2026 09:28

Poly-J force-pushed the secu_dev branch from f9db526 to 87d3373 Compare April 17, 2026 09:28

jun.pan added 3 commits April 17, 2026 17:45

os/se/armino: Optimize the return value of the interface

986e7b7

Change the return value of the interface so that when an error occurs, the internal error code is directly displayed, making it easier to locate the problem.

os/se/armino: Optimize log output level control

270a749

Use sedbg and sevdbg to distinguish different log information.

os/board/bk7239n: update the closed-source tfm library

96f9a66

Since implementing the powercut function for the ss partition changed the logic in tfm, it is necessary to synchronously update the closed-source tfm library.

Poly-J force-pushed the secu_dev branch from 87d3373 to 96f9a66 Compare April 17, 2026 09:49

jylee9613 approved these changes Apr 17, 2026

View reviewed changes

Conversation

Poly-J commented Apr 16, 2026

Uh oh!

ewoodev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

xiaotao-yuan commented Apr 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ewoodev commented Apr 17, 2026

Uh oh!

xiaotao-yuan commented Apr 17, 2026

Uh oh!

ewoodev left a comment

Choose a reason for hiding this comment

Uh oh!

jylee9613 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants