Skip to content

os/arch/arm/src, os/include/tinyara/reboot_reason.h: Add specific reboot reasons and improve error tracking #7196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhinav-s235 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

os/arch/arm/src, os/include/tinyara/reboot_reason.h: Add specific reboot reasons and improve error tracking #7196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions os/arch/arm/src/armino/armino_allocateheap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
#include <tinyara/mm/mm.h>
#include <tinyara/kmalloc.h>
#include <tinyara/mm/heap_regioninfo.h>
#include <tinyara/reboot_reason.h>

#if defined(CONFIG_BUILD_PROTECTED) && defined(CONFIG_MM_KERNEL_HEAP)
#include <string.h>
Expand Down Expand Up @@ -162,6 +163,9 @@ void up_add_kregion(void)
lldbg("ERROR: Failed to allocate kheap for ram region configuration\n");
lldbg("Region start = 0x%x region end = 0x%x\n_sdata = 0x%x end of stack = 0x%x\n",
kregionx_start[region_cnt], kregionx_end, &_sdata, stack_end);
#ifdef CONFIG_SYSTEM_REBOOT_REASON
up_reboot_reason_write(REBOOT_SYSTEM_MEMORYALLOCFAIL);
#endif
PANIC();
} else if (stack_end >= (void *)kregionx_start[region_cnt] && stack_end < (void *)kregionx_end) {
heap_start = stack_end;
Expand Down
4 changes: 4 additions & 0 deletions os/arch/arm/src/armino/armino_watchdog_lowerhalf.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
#include <tinyara/watchdog.h>
#include <tinyara/irq.h>
#include <tinyara/arch.h>
#include <tinyara/reboot_reason.h>
#include "wdt.h"
#include "hal_aon_rtc_types.h"
#include "aon_rtc.h"
Expand Down Expand Up @@ -176,6 +177,9 @@ static int armino_nmi_interrupt(int irq, void *context, FAR void *arg)
}
aon_pmu_drv_wdt_change_not_rosc_clk();
aon_pmu_drv_wdt_rst_dev_enable();
#ifdef CONFIG_SYSTEM_REBOOT_REASON
up_reboot_reason_write(REBOOT_SYSTEM_WATCHDOG);
#endif
PANIC();
while(1);
}
Expand Down
3 changes: 3 additions & 0 deletions os/arch/arm/src/armv7-a/arm_doirq.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ uint32_t *arm_doirq(int irq, uint32_t *regs)

board_autoled_on(LED_INIRQ);
#ifdef CONFIG_SUPPRESS_INTERRUPTS
#ifdef CONFIG_SYSTEM_REBOOT_REASON
up_reboot_reason_write(REBOOT_SYSTEM_INTERRUPT_FAILURE);
#endif
PANIC();
#else
/* Nested interrupts are not supported */
Expand Down
4 changes: 4 additions & 0 deletions os/arch/arm/src/armv7-a/arm_pthread_start.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
#include <tinyara/config.h>
#include <pthread.h>
#include <tinyara/arch.h>
#include <tinyara/reboot_reason.h>

#include <assert.h>

Expand Down Expand Up @@ -86,6 +87,9 @@ void up_pthread_start(pthread_startroutine_t entrypt, pthread_addr_t arg)

sys_call2(SYS_pthread_start, (uintptr_t) entrypt, (uintptr_t) arg);

#ifdef CONFIG_SYSTEM_REBOOT_REASON
up_reboot_reason_write(REBOOT_SYSTEM_PTHREAD_START_FAILURE);
#endif
PANIC();
}

Expand Down
4 changes: 4 additions & 0 deletions os/arch/arm/src/armv7-a/arm_reprioritizertr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
#include <debug.h>
#include <tinyara/arch.h>
#include <tinyara/sched.h>
#include <tinyara/reboot_reason.h>

#include "sched/sched.h"
#include "group/group.h"
Expand Down Expand Up @@ -91,6 +92,9 @@ void up_reprioritize_rtr(struct tcb_s *tcb, uint8_t priority)
|| priority > SCHED_PRIORITY_MAX
#endif
) {
#ifdef CONFIG_SYSTEM_REBOOT_REASON
up_reboot_reason_write(REBOOT_SYSTEM_SCHEDULER_FAILURE);
#endif
DEBUGPANIC();
} else {
struct tcb_s *rtcb = this_task();
Expand Down
4 changes: 4 additions & 0 deletions os/arch/arm/src/armv7-a/arm_task_start.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@

#include <tinyara/config.h>
#include <tinyara/arch.h>
#include <tinyara/reboot_reason.h>

#include <assert.h>

Expand Down Expand Up @@ -85,6 +86,9 @@ void up_task_start(main_t taskentry, int argc, char *argv[])

sys_call3(SYS_task_start, (uintptr_t)taskentry, (uintptr_t)argc, (uintptr_t)argv);

#ifdef CONFIG_SYSTEM_REBOOT_REASON
up_reboot_reason_write(REBOOT_SYSTEM_TASK_START_FAILURE);
#endif
PANIC();
}

Expand Down
4 changes: 4 additions & 0 deletions os/arch/arm/src/armv7-m/up_doirq.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
#include <tinyara/arch.h>
#include <arch/board/board.h>
#include <tinyara/security_level.h>
#include <tinyara/reboot_reason.h>

#include "up_arch.h"
#include "up_internal.h"
Expand Down Expand Up @@ -102,6 +103,9 @@ uint32_t *up_doirq(int irq, uint32_t *regs)
#endif
board_led_on(LED_INIRQ);
#ifdef CONFIG_SUPPRESS_INTERRUPTS
#ifdef CONFIG_SYSTEM_REBOOT_REASON
up_reboot_reason_write(REBOOT_SYSTEM_INTERRUPT_FAILURE);
#endif
PANIC();
#else

Expand Down
4 changes: 4 additions & 0 deletions os/arch/arm/src/armv7-m/up_reprioritizertr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
#include <sched.h>
#include <debug.h>
#include <tinyara/arch.h>
#include <tinyara/reboot_reason.h>

#include "sched/sched.h"
#include "up_internal.h"
Expand Down Expand Up @@ -117,6 +118,9 @@ void up_reprioritize_rtr(struct tcb_s *tcb, uint8_t priority)
|| priority > SCHED_PRIORITY_MAX
#endif
) {
#ifdef CONFIG_SYSTEM_REBOOT_REASON
up_reboot_reason_write(REBOOT_SYSTEM_SCHEDULER_FAILURE);
#endif
PANIC();
} else {
struct tcb_s *rtcb = this_task();
Expand Down
4 changes: 4 additions & 0 deletions os/arch/arm/src/armv7-r/arm_doirq.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@

#include <tinyara/board.h>
#include <arch/board/board.h>
#include <tinyara/reboot_reason.h>

#include "up_arch.h"
#include "up_internal.h"
Expand Down Expand Up @@ -94,6 +95,9 @@ uint32_t *arm_doirq(int irq, uint32_t *regs)
board_autoled_on(LED_INIRQ);

#ifdef CONFIG_SUPPRESS_INTERRUPTS
#ifdef CONFIG_SYSTEM_REBOOT_REASON
up_reboot_reason_write(REBOOT_SYSTEM_INTERRUPT_FAILURE);
#endif
PANIC();
#else
/* Nested interrupts are not supported */
Expand Down
4 changes: 4 additions & 0 deletions os/arch/arm/src/armv7-r/arm_reprioritizertr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
#include <debug.h>
#include <tinyara/arch.h>
#include <tinyara/sched.h>
#include <tinyara/reboot_reason.h>

#include "sched/sched.h"
#include "group/group.h"
Expand Down Expand Up @@ -106,6 +107,9 @@ void up_reprioritize_rtr(struct tcb_s *tcb, uint8_t priority)
|| priority > SCHED_PRIORITY_MAX
#endif
) {
#ifdef CONFIG_SYSTEM_REBOOT_REASON
up_reboot_reason_write(REBOOT_SYSTEM_SCHEDULER_FAILURE);
#endif
PANIC();
} else {
struct tcb_s *rtcb = this_task();
Expand Down
4 changes: 4 additions & 0 deletions os/arch/arm/src/armv8-m/up_doirq.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
#include <tinyara/arch.h>
#include <arch/board/board.h>
#include <tinyara/security_level.h>
#include <tinyara/reboot_reason.h>

#include "up_arch.h"
#include "up_internal.h"
Expand Down Expand Up @@ -102,6 +103,9 @@ uint32_t *up_doirq(int irq, uint32_t *regs)
#endif
board_led_on(LED_INIRQ);
#ifdef CONFIG_SUPPRESS_INTERRUPTS
#ifdef CONFIG_SYSTEM_REBOOT_REASON
up_reboot_reason_write(REBOOT_SYSTEM_INTERRUPT_FAILURE);
#endif
PANIC();
#else

Expand Down
4 changes: 4 additions & 0 deletions os/arch/arm/src/armv8-m/up_reprioritizertr.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
#include <sched.h>
#include <debug.h>
#include <tinyara/arch.h>
#include <tinyara/reboot_reason.h>

#include "sched/sched.h"
#include "up_internal.h"
Expand Down Expand Up @@ -121,6 +122,9 @@ void up_reprioritize_rtr(struct tcb_s *tcb, uint8_t priority)
|| priority > SCHED_PRIORITY_MAX
#endif
) {
#ifdef CONFIG_SYSTEM_REBOOT_REASON
up_reboot_reason_write(REBOOT_SYSTEM_SCHEDULER_FAILURE);
#endif
PANIC();
} else {
struct tcb_s *rtcb = this_task();
Expand Down
7 changes: 7 additions & 0 deletions os/arch/arm/src/common/up_allocateheap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
#include <tinyara/mm/mm.h>
#include <tinyara/kmalloc.h>
#include <tinyara/mm/heap_regioninfo.h>
#include <tinyara/reboot_reason.h>

#if defined(CONFIG_BUILD_PROTECTED) && defined(CONFIG_MM_KERNEL_HEAP)
#include <string.h>
Expand Down Expand Up @@ -134,6 +135,9 @@ void up_allocate_kheap(FAR void **heap_start, size_t *heap_size)
if ((void *)&_sdata <= (void *)KREGION_END && stack_end >= (void *)KREGION_END) {
lldbg("ERROR: Failed to allocate kheap for ram region configuration\n");
lldbg("Region start = 0x%x region end = 0x%x\n_sdata = 0x%x end of stack = 0x%x\n", KREGION_START, KREGION_END, &_sdata, stack_end);
#ifdef CONFIG_SYSTEM_REBOOT_REASON
up_reboot_reason_write(REBOOT_SYSTEM_MEMORYALLOCFAIL);
#endif
PANIC();
} else if (stack_end >= (void *)KREGION_START && stack_end < (void *)KREGION_END) {
*heap_start = stack_end;
Expand Down Expand Up @@ -171,6 +175,9 @@ void up_add_kregion(void)
if ((void *)&_sdata <= (void *)kregionx_end && stack_end >= (void *)kregionx_end) {
lldbg("ERROR: Failed to allocate kheap for ram region configuration\n");
lldbg("Region start = 0x%x region end = 0x%x\n_sdata = 0x%x end of stack = 0x%x\n", kregionx_start[region_cnt], kregionx_end, &_sdata, stack_end);
#ifdef CONFIG_SYSTEM_REBOOT_REASON
up_reboot_reason_write(REBOOT_SYSTEM_MEMORYALLOCFAIL);
#endif
PANIC();
} else if (stack_end >= (void *)kregionx_start[region_cnt] && stack_end < (void *)kregionx_end) {
heap_start = stack_end;
Expand Down
4 changes: 4 additions & 0 deletions os/arch/arm/src/common/up_checkstackoverflow.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include <tinyara/arch.h>
#include <tinyara/sched.h>
#include <tinyara/irq.h>
#include <tinyara/reboot_reason.h>

#include <assert.h>
#include <debug.h>
Expand Down Expand Up @@ -93,6 +94,9 @@ void up_checkstackoverflow(FAR struct tcb_s *rtcb)
lldbg_noarg("###################\n");
lldbg_noarg("Stack base pointer (corrupted value) : %p", (void *)(rtcb->stack_base_ptr));
}
#ifdef CONFIG_SYSTEM_REBOOT_REASON
up_reboot_reason_write(REBOOT_SYSTEM_STACK_OVERFLOW);
#endif
PANIC();
leave_critical_section(flags);
}
Expand Down
5 changes: 5 additions & 0 deletions os/include/tinyara/reboot_reason.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ typedef enum {
REBOOT_SYSTEM_BINARY_RECOVERYFAIL = 58, /* Binary Recovery Fail */
REBOOT_SYSTEM_PERIODIC_REBOOT = 59, /* Periodic reboot */
REBOOT_SYSTEM_ASSERT = 60, /* Reboot from ASSERT or PANIC */
REBOOT_SYSTEM_INTERRUPT_FAILURE = 61, /* Interrupt handling failure */
REBOOT_SYSTEM_SCHEDULER_FAILURE = 62, /* Scheduler/reprioritization failure */
Copy link
Copy Markdown
Contributor

@seokhun-eom24 seokhun-eom24 Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add REBOOT_SYSTEM_SCHEDULER_FAILURE, REBOOT_SYSTEM_INTERRUPT_FAILURE into armv7-m and armv7-r also.

Copy link
Copy Markdown
Contributor Author

@abhinav-s235 abhinav-s235 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

REBOOT_SYSTEM_TASK_START_FAILURE = 63, /* Task start failure */
REBOOT_SYSTEM_PTHREAD_START_FAILURE = 64, /* Pthread start failure */
REBOOT_SYSTEM_STACK_OVERFLOW = 65, /* Stack overflow detected */

REBOOT_NETWORK_WIFICORE_WATCHDOG = 80, /* Wi-Fi Core Watchdog Reset */
REBOOT_NETWORK_WIFICORE_PANIC = 81, /* Wi-Fi Core Panic */
Expand Down