Merged
Conversation
dayo09
commented
Apr 10, 2025
| name: Check commit message | ||
| runs-on: ubuntu-22.04 | ||
| # Skip on draft, check on draft -> ready | ||
| if: github.repository_owner == 'Samsung' && github.event.pull_request.draft == false |
Contributor
Author
There was a problem hiding this comment.
It keeps skipping without this change.
dayo09
commented
Apr 10, 2025
| run: | | ||
| # Get commit body | ||
| git log origin/${GITHUB_BASE_REF}..HEAD --format=%b > commit_msg.txt | ||
| git log origin/"$GITHUB_BASE_REF"..HEAD --format=%b > commit_msg.txt |
Contributor
Author
There was a problem hiding this comment.
It's for actionlint linter warning.
Contributor
There was a problem hiding this comment.
(Just out of curiosity)
Does it require to remove braces or to add double quotes?
Contributor
Author
There was a problem hiding this comment.
@miusic It asked me to add double quotes. And the bracket looked redundant to me so I removed it :-D
dayo09
commented
Apr 10, 2025
|
|
||
| # Check string starting from "TICO-DCO-1.0-Signed-off-by:" | ||
| count=$(grep -c "TICO-DCO-1.0-Signed-off-by:" commit_body.txt) | ||
| count="$(grep -c "TICO-DCO-1.0-Signed-off-by:" commit_body.txt)" |
Contributor
Author
There was a problem hiding this comment.
It's for actionlint linter warning.
Let's fix it to run. TICO-DCO-1.0-Signed-off-by: Dayoung Lee <dayoung.lee@samsung.com>
dayo09
commented
Apr 10, 2025
miusic
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's fix it to run.
TICO-DCO-1.0-Signed-off-by: Dayoung Lee dayoung.lee@samsung.com
✔️ Checked that it does not skip
✔️ Checked that it fails without signoff
✔️ Checked that it passes with signoff