[test] Rename tests according to the convention#152
Conversation
This commit renames tests according to the convention. TICO-DCO-1.0-Signed-off-by: seongwoo <mhs4670go@naver.com>
|
|
||
| class NotMergedConsecutiveCatTest1(SinglePassValueTest): | ||
| def test_pass(self): | ||
| def test_pass_neg(self): |
There was a problem hiding this comment.
May I ask why this test is marked as negative?
I guess that this test is more fit to the positive test according to the convention in #151
There was a problem hiding this comment.
Well, the net failed to meet the condition of the pass. Can we really say it is a positive test case?
There was a problem hiding this comment.
But, let's clarify the comment for the readers.
There was a problem hiding this comment.
Hmm.. 🤔 then, how about to check a condition like below after the pass is run?
self.assertNotEqual(num_of_ops(self.exported_program(), ops.aten.cat), 1)There was a problem hiding this comment.
Above suggestion is just an optional one
I understand your intention thanks to your comment 😄 #152 (comment)
|
|
||
| class NotMergedConsecutiveCatTest2(SinglePassValueTest): | ||
| def test_pass(self): | ||
| def test_pass_neg(self): |
There was a problem hiding this comment.
miusic
left a comment
miusic
left a comment
There was a problem hiding this comment.
LGTM with minor comment 😄 #152 (comment)
4 participants
This commit renames tests according to the convention.
Related: #151
TICO-DCO-1.0-Signed-off-by: seongwoo mhs4670go@naver.com