Skip to content

1962 recreate samf3 navbar in samf 4#1966

Open
Madt2 wants to merge 69 commits intomasterfrom
1962-recreate-samf3-navbar-in-samf-4
Open

1962 recreate samf3 navbar in samf 4#1966
Madt2 wants to merge 69 commits intomasterfrom
1962-recreate-samf3-navbar-in-samf-4

Conversation

@Madt2
Copy link
Contributor

@Madt2 Madt2 commented Sep 18, 2025

Not quite the same navbar, but similar enough

@Madt2 Madt2 linked an issue Sep 18, 2025 that may be closed by this pull request
@Madt2 Madt2 self-assigned this Sep 18, 2025
@Madt2 Madt2 requested review from hei98 and smistad September 18, 2025 17:53
@Madt2 Madt2 enabled auto-merge (squash) September 18, 2025 17:56
@Madt2 Madt2 disabled auto-merge September 18, 2025 17:56
@Madt2 Madt2 requested a review from robines October 16, 2025 19:55
dependabot bot and others added 14 commits January 15, 2026 21:18
Bumps [debugpy](https://github.com/microsoft/debugpy) from 1.8.14 to 1.8.17.
- [Release notes](https://github.com/microsoft/debugpy/releases)
- [Commits](microsoft/debugpy@v1.8.14...v1.8.17)

---
updated-dependencies:
- dependency-name: debugpy
  dependency-version: 1.8.17
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add color palette

* Add basic variables for text colors
* Create NewBadge component

* biome
* Create Block composite components

* Fix descending specificity

* Decrease intensity of header/footer gradients slightly

* Add storybook file

* Remove storybook file (our new font isnt loading)
* Begin creating new event card component

* Set all anchor tags' text-decoration to none

* Use NewBadge. biome

* adjust z-index

* Add box shadow to event badge

* Use placeholder image

* Start badge and CTA logic, display location. Tweak styling

Also:
* Add blue badge theme
* Fix and adjust TimeDisplay event formatting

* Rename NewEventCard to EventCard

* Make Badge inline-flex, add outline-white theme

* Remove a tag color specification in themes

* Fix merge: add back Block example in ComponentPage

* Block: slightly decrease opacity of footer gradient and decrease header

* Block: Improve gradients through easing

* BlockImage: Use background-image instead of img element

* Use Block components in EventCard

* Block: Add white theme

* Add text shadow to bottom text and show event category

* Update location class name

* biome

* Show translated event category

* Simplify fake events creation in ComponentPage

* Set letter-spacing for BlockTitle

* Update component page

* Change "free" badge to green theme

* Round edges more, sharpen on hover

* Nesten utsolgt -> Få billetter igjen

Matches samf3

* Switch out Buy ticket arrow icon

* Create EventCardContainer. Allow more customization of EventCard/Block

* Fix biome & stylelint

* Don't show CTA if event is free
Copy link
Contributor

@andsamfu andsamfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser ikke at dark mode knappen dukker opp på mobil:

image

Copy link
Contributor

@andsamfu andsamfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Husker ikke om vi har diskutert dette tidligere, men ser ikke knappen for "medlem" som sikkert burde ha vært der.

image

Copy link
Contributor

@andsamfu andsamfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Logg inn" knappen kan heller stå som "intern" slik som det er på samfundet.no slik at det ikke blir misforståelser mellom intern, medlem og søker.

@Madt2
Copy link
Contributor Author

Madt2 commented Jan 20, 2026

Ser ikke at dark mode knappen dukker opp på mobil:

image

fikset

@robines
Copy link
Member

robines commented Jan 20, 2026

"Logg inn" knappen kan heller stå som "intern" slik som det er på samfundet.no slik at det ikke blir misforståelser mellom intern, medlem og søker.

Nja, uenig. Denne renamingen i fea7e5c bør revertes.

Samf4 sitt brukersystem skiller ikke på søkerprofil og vanlige brukere slik som samf3 gjør. Siden søkere skal også bruke det vanlige brukersystemet gir det ikke mening å endre knappen til "Intern". Behold "Logg inn".

@andsamfu
Copy link
Contributor

Nja, uenig. Denne renamingen i fea7e5c bør revertes.

Samf4 sitt brukersystem skiller ikke på søkerprofil og vanlige brukere slik som samf3 gjør. Siden søkere skal også bruke det vanlige brukersystemet gir det ikke mening å endre knappen til "Intern". Behold "Logg inn".

Da er jeg enig i å beholde det til "Logg inn". Trodde søkere og interne var to forskjellige brukere slik som på samf3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recreate samf3 navbar in samf 4

5 participants