-
Notifications
You must be signed in to change notification settings - Fork 25
Meson compiler test #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meson compiler test #399
Changes from all commits
d74e29e
50d04d7
b29e4cf
2375ba3
a15fb1d
447bf82
8ee2ed2
bf917cd
886d32b
d82b76a
f5a936a
d8bac70
31f653d
c59f88c
a8ae110
aea7ab2
322ae7d
2cece71
fb2940c
c615eb9
bbce5ea
7d7683a
f283d67
d59b02c
e1559a9
5d758cf
13c096f
824d9e2
7380b45
9c34f4a
0648b38
65f8144
3a8146c
ce5a01c
409200c
717ba11
be9cf60
575e4c9
3e1a87f
da4a962
a2bc1d4
dcf24fe
991096c
8c0b8d2
79974cf
f98d35e
c2315c0
226dbc2
e6a6aa5
5603e93
d9f7761
d4274f8
f68d236
c026bcb
f6e8432
921198c
43e8c9b
a635bae
524c141
6386d5a
799a08c
ddb85a5
c209900
081aead
ab91b70
2120282
b76d76f
d252d89
68693b0
062eb1a
993bcd4
c8b17d2
b1a6da7
085ae83
724fecd
5aaac30
da1b857
afb9406
9147f72
5b8bae3
940d2a9
c3db048
886db3a
9d5cc07
99c7d2d
5317fb9
bb85744
f00f8a3
c20d8c6
0ad927f
042e9f7
037220a
78a88f2
f36021d
775c517
146a746
b2c9e4a
e4d20bf
f4c4649
ee1965f
0ebd175
dde3aec
577799b
d2b68f1
3b59b3c
d48dd5f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| name: Build and Test | ||
|
|
||
| on: [push, pull_request] | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: 3.12 | ||
|
|
||
| - name: Install system dependencies | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y libblas-dev liblapack-dev gfortran pkg-config | ||
|
|
||
| - name: Install Python dependencies | ||
| run: | | ||
| pip install meson ninja meson-python numpy scipy ase pytest | ||
|
|
||
| - name: Setup build directory | ||
| run: meson setup builddir | ||
|
|
||
| - name: Compile | ||
| run: meson compile -C builddir | ||
|
|
||
|
|
||
| # - name: Install package | ||
| # run: meson install -C builddir | ||
|
|
||
| # - name: Run tests | ||
| # run: meson test -C builddir |
mesonepigreco marked this conversation as resolved.
Show resolved
Hide resolved
|
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The installation of setuptools=64 must be removed, as this was related to the old build that required a very old version of setuptools.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note that this occurs multiple times throught this file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave the requirement for python >=3.8 and <=3.12, otherwise it is a breaking change as python 3.12 is a breaking release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, we can fix the version control on cellconstructor by forcing a local environment installation of python. We first install cellconstructor from the github repository, which is the 1.5, then we force the python-sscha installation without creating the isolation build (that only looks at pypy for packages):
For this to work, we must manually install meson before running the installation, otherwise pip will complain.