Merged
Conversation
Ran into an error where we couldn't change the column name and therefore couldn't access the ra and dec values.
Reference text may not be in the correct format
Collaborator
|
This looks great! I'll try to review it ASAP. |
There was a problem hiding this comment.
Copilot reviewed 128 out of 148 changed files in this pull request and generated no comments.
Files not reviewed (20)
- data/reference/Publications.json: Language not supported
- data/reference/Versions.json: Language not supported
- data/source/2mass_j00554279+1301043.json: Language not supported
- data/source/2mass_j01151621+3130061.json: Language not supported
- data/source/2mass_j03361338+0010129.json: Language not supported
- data/source/2mass_j04470652-1946392.json: Language not supported
- data/source/2mass_j08121049+3723223.json: Language not supported
- data/source/2mass_j08220659+0441026.json: Language not supported
- data/source/2mass_j08503941-0221528.json: Language not supported
- data/source/2mass_j08554875+3636020.json: Language not supported
- data/source/2mass_j09481253-2903268.json: Language not supported
- data/source/2mass_j10353492-0711479.json: Language not supported
- data/source/2mass_j12191495+0810307.json: Language not supported
- data/source/2mass_j12204296+6205315.json: Language not supported
- data/source/2mass_j12451711+6016103.json: Language not supported
- data/source/2mass_j13512249+1419168.json: Language not supported
- data/source/2mass_j14114474-4524153.json: Language not supported
- data/source/2mass_j14183233+0253259.json: Language not supported
- data/source/2mass_j14250510+7102097.json: Language not supported
- data/source/2mass_j14351706-0147115.json: Language not supported
Collaborator
|
I think this is done!! GREAT GREAT WORK @lesliech1004 and @kaseyLee123!! |
dr-rodriguez
approved these changes
Apr 14, 2025
5 tasks
lesliech1004
added a commit
to lesliech1004/SIMPLE-db
that referenced
this pull request
Jul 23, 2025
* Worked on Ingest Sources for BONES_Archive * Worked on publications and accessing the ADS keys * Changed csv file. Manuallly ingested ULAS J074431.30+283915.6. * Changed csv file. Correct bones_archive data * Updated JSON files and pytest cases. * remove unicode from Lupine paper * add and clean up test_data.py * JSON files * versions table update * add the version thing back __version__ --------- Co-authored-by: Kelle Cruz <kellecruz@gmail.com> Co-authored-by: Kasey Lee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description: ingest sources in photometry from the BONES archive
Link to relevant issue: Closes #544 (sources only)
For data ingests: