Merged
Conversation
Collaborator
|
Please include at least one example FITS file with this PR. |
Collaborator
|
Both of those notebooks looks pretty sparse. Did you mean to include a different one? |
Contributor
Author
|
Yes, you are correct that was the wrong file. I have added the actual script. |
Collaborator
|
Nice -- great start! spec = Spectrum1D(spectral_axis=wave, flux=flux, uncertainty=err)
spec.meta["header"] = header
spec.write(<filename>, format="tabular-fits") |
Collaborator
|
could you also add the original fits file? |
kelle
changed the title
…b into Roth24-spectra
…b into Roth24-spectra
Contributor
canavarrete01
left a comment
canavarrete01
left a comment
There was a problem hiding this comment.
I like the changes made to test_spectra_utils here I think they do a good job in clarifying errors for the user. Looks all good to me
canavarrete01
approved these changes
May 22, 2025
lesliech1004
pushed a commit
to lesliech1004/SIMPLE-db
that referenced
this pull request
Jul 23, 2025
…AstroDB#581) * Adding scripts and CSV files for converting and ingesting spectra. * improvements to ingest_spectra and Roth24 ingest script * spectra function improvements * json files * Version update --------- Co-authored-by: kelle <kellecruz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spectra from Rothermich et al. 2024.
Link to relevant issue: Closes #546
For data ingests: