Added sin, cos, and tan operations to fixed point implementation#1753
Conversation
copying.md
Outdated
| | Michael Lynch | mtlynch | git à mtlynch dawt io | | ||
| | Ngô Xuân Minh | | xminh dawt ngo dawt 00 à gmail dawt com | | ||
| | Haytham Tang | haytham918 | yunxuant à umich dawt edu | | ||
| | Ana Trias-Labellarte | anatriaslabella | ana.triaslabella@ufl.edu | |
There was a problem hiding this comment.
shouldn't your email be in the same format as the others?
There was a problem hiding this comment.
Just fixed it and committed it, thank you! Not sure why the rest of the table format is not passing certain checks.
There was a problem hiding this comment.
Nice, You're probably going to have to undo all the changes to the other lines you've made (I'm not sure what you've changed but git is saying you have done something)
heinezen
force-pushed
the
Open-source-contribution
branch
3 times, most recently
from
9ec3857 to
ba1fc92
Compare
heinezen
left a comment
heinezen
left a comment
There was a problem hiding this comment.
Hey sorry this took so long to get back to. I fixed your table by squashing your commits and reformatting the whole thing.
Your solution is not exactly what we want because we want the calculations and results to be fixed-point as well instead of just converting to a floatiing point number. This is necessary to keep the calculations deterministic. I added your changes anyway, since they can also be useful :)
heinezen
force-pushed
the
Open-source-contribution
branch
from
ba1fc92 to
d78750b
Compare
heinezen
force-pushed
the
Open-source-contribution
branch
from
d78750b to
81b0443
Compare
3 participants
As a first-time open source contributor, I decided to try implementing additional fixed-point math operTations that were requested that may be nice to see, specifically the trigonometric operations sin, cos, and tan. I hope my code is sufficient to solve this issue!