Skip to content

Conversation

@jberger7
Copy link

@jberger7 jberger7 commented Jan 7, 2026

Description

Please provide a detailed description of the changes this pull request introduces. If available, also link to a docdb link where the issue/change have been presented on/discussed.

The form factor initially implemented for Higgs Portal Scalar decays into pions in MeVPrtl was based off of an outdated, incorrect model. This request updates the form factor to conform to the numerical determination in arXiv:1909.11670v4 and references therein. A numerical fit was performed to determine the form factor based on the left panel of Fig. 1 in 1909.11670v4. This new form factor is left optional (on by default, but the old form factor can be recovered with an appropriate flag) for the purposes of reproducing existing simulated data.

  • Have you added a label? (bug/enhancement/physics etc.)

This is pull request to add a new fix to the physics modeling of Higgs Portal Scalar decays in MeVPrtl.

  • Have you assigned at least 1 reviewer?

gputnam and jamiecd have offered to act as reviewers for this request.

  • Is this PR related to an open issue / project?

This request is related to an open issue in the physics modeling, but is not fixing any coding bugs.

  • Does this PR affect CAF data format? If so, please assign a CAF maintainer as additional reviewer.

No effect.

  • Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)? If so, please link it in the description.

No effect on other repositories.

  • Are you submitting this PR on behalf of someone else who made the code changes? If so, please mention them in the description.

No. The changes were made by me.

Add a parameter to determine whether new form factor is used
Added an optional new form factor to use for determining decays of Higgs portal scalar to pions
Fixed an error with the new form factor implementation
Corrected a typo in setting the Boolean for the new form factor.
Corrected a typo in the new parameter name for the form factor selection
Fixed a bug with setting the boolean for the new form factor
Simplified the form factor calculation (with some speed improvement)
@jberger7 jberger7 requested review from gputnam and jamiecd January 7, 2026 19:36
@kjplows
Copy link
Contributor

kjplows commented Jan 8, 2026

trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_02 SBNSoftware/sbncode@v10_14_02 SBNSoftware/sbn*@SBN_SUITE_v10_14_02

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@kjplows kjplows moved this from Testing to To merge in SBN software development Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To merge

Development

Successfully merging this pull request may close these issues.

6 participants