-
Notifications
You must be signed in to change notification settings - Fork 35
Jberger7 new form factor #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Add a parameter to determine whether new form factor is used
Added an optional new form factor to use for determining decays of Higgs portal scalar to pions
Fixed an error with the new form factor implementation
Corrected a typo in setting the Boolean for the new form factor.
Corrected a typo in the new parameter name for the form factor selection
Fixed a bug with setting the boolean for the new form factor
Simplified the form factor calculation (with some speed improvement)
|
trigger build LArSoft/lar*@LARSOFT_SUITE_v10_14_02 SBNSoftware/sbncode@v10_14_02 SBNSoftware/sbn*@SBN_SUITE_v10_14_02 |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build SBND phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
Description
Please provide a detailed description of the changes this pull request introduces. If available, also link to a docdb link where the issue/change have been presented on/discussed.
The form factor initially implemented for Higgs Portal Scalar decays into pions in MeVPrtl was based off of an outdated, incorrect model. This request updates the form factor to conform to the numerical determination in arXiv:1909.11670v4 and references therein. A numerical fit was performed to determine the form factor based on the left panel of Fig. 1 in 1909.11670v4. This new form factor is left optional (on by default, but the old form factor can be recovered with an appropriate flag) for the purposes of reproducing existing simulated data.
This is pull request to add a new fix to the physics modeling of Higgs Portal Scalar decays in MeVPrtl.
gputnam and jamiecd have offered to act as reviewers for this request.
This request is related to an open issue in the physics modeling, but is not fixing any coding bugs.
No effect.
No effect on other repositories.
No. The changes were made by me.