feat(fiori tools settings): app info page setting - #5031
Open
korotkovao wants to merge 11 commits into
Open
Conversation
… Info Page auto-open Add support for ApplicationWizard.autoOpenApplicationInfoPage setting to control whether the Application Info Page opens automatically after project generation. Changes: - Add getConfiguration parameter to loadApplicationInfoFromSettings() - Check ApplicationWizard.autoOpenApplicationInfoPage setting (default: true) - Only execute command if setting is enabled - Backwards compatible: defaults to true if getConfiguration not provided Related to yeoman-ui setting added in app-studio-toolkit.
Add comprehensive tests for the getConfiguration parameter: - Test setting disabled (command should NOT execute) - Test setting enabled (command should execute) - Test default behavior when getConfiguration not provided (enabled) - Test fallback when getConfiguration returns undefined (enabled) All tests passing. Coverage: 100% statements, 93.33% branches. Changeset: minor - new optional parameter for VS Code setting check.
…ings/app-info-page-setting
🦋 Changeset detectedLatest commit: 778c46d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![hyperspace-pr-bot[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The changeset summary uses feat(fiori-tools-settings): instead of the required FEAT: prefix, which will cause pnpm validate:changesets to fail in CI. The source code and test changes themselves are clean, well-structured, and backwards-compatible. The author should fix the changeset prefix before merging.
Co-authored-by: hyperspace-pr-bot[bot] <209611008+hyperspace-pr-bot[bot]@users.noreply.github.com>
korotkovao
changed the title
IainSAP
reviewed
Aug 7, 2026
Change function signature from callback-based getConfiguration to simple
autoOpen boolean parameter for better testability and clarity.
Before:
getConfiguration?: () => { get<T>(...) }
After:
autoOpen: boolean = true
Defaults to true for backward compatibility (maintains existing auto-open
behavior when parameter not provided).
Addresses PR review feedback from Iain O'Farrell.
Add writeApplicationInfoSettings as deprecated alias for addGeneratedFiles to maintain backward compatibility with existing consumers. Fixes build error in fiori-app-sub-generator and other packages that import writeApplicationInfoSettings.
…eratedFiles When appInfo.json doesn't exist, fs.readJSON returns undefined. Added fallback to empty object with latestGeneratedFiles array to prevent 'Cannot read properties of undefined' error. Fixes test failures in repo-app-import-sub-generator.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for a new VS Code setting
ApplicationWizard.autoOpenApplicationInfoPageto control whether the Application Info Page automatically opens after project generation in the@sap-ux/fiori-tools-settingspackage.The
loadApplicationInfoFromSettings()function now accepts an optionalgetConfigurationparameter that allows callers to pass in the VS Code configuration accessor. When the setting is disabled (false), the Application Info Page will not auto-open, though theappInfo.jsonfile will still be cleaned up. The change is fully backwards compatible — whengetConfigurationis not provided, the behavior defaults to enabled (true).Changes:
applicationInfoHandler.ts— Added optionalgetConfigurationparameter toloadApplicationInfoFromSettings()and a setting check before executing the open commandapplicationInfoHandler.test.ts— Added test cases covering: setting disabled, setting enabled, missinggetConfiguration, andgetConfigurationreturningundefined.changeset/app-info-page-setting.md— Changeset entry for the minor version bumpType of change
How have you tested?
New unit tests added covering all relevant scenarios:
getConfigurationprovided → defaults to enabled (command executed)getConfigurationreturnsundefined→ defaults to enabled via fallbackChecklist:
The code conforms to the general development principles
Supplied as many details as possible on this change
The code is easy to read and maintainable by others
Corresponding changes to the documentation has been done
Already existing and new unit tests pass locally
🔄 Regenerate and Update Summary
PR Bot Information
Version:
1.29.18issue_comment.edited7b085470-91ce-11f1-9ee6-84bac9b3216a