fix(fiori-mcp): validate metadata output directory - #5014
Draft
Pybsama wants to merge 1 commit into
Draft
Conversation
Fixes SAP#4981 Signed-off-by: sama Pyb <peiyibopybsama@gmail.com>
🦋 Changeset detectedLatest commit: 3576ef0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4981.
download_odata_service_metadatanow rejects a missingappPathbefore system lookup, metadata download, or file writes. The exposed input schema now states that the output directory must already exist, that this tool does not create directories, and thatgenerate_fiori_app_odatashould be used when creating a new application. This also adds regression coverage and a patch changeset.AI assistance: OpenAI Codex was used to assist with issue analysis, implementation, test authoring, and review. I reviewed the changes and test results; no third-party material was intentionally included.
Type of change
How have you tested?
@sap-ux/fiori-mcp-servertest suite: 31 suites, 396 tests, and 35 snapshots passed.git diff --checkpassed.Checklist: