chore: overhaul CODEOWNERS and document new review process - #4999
Conversation
Replace ~30 fine-grained teams with 7 domain teams + architects cross-cutting group. Cover ~40 previously-unowned packages. Add +2 review model, Hyperspace bot expectations, single review channel, SLA, and author responsibilities to CONTRIBUTING.md. Add Hyperspace bot checkbox to PR template.
|
SummaryThe following content is AI-generated and provides a summary of the pull request: DescriptionThis PR overhauls the repository's CODEOWNERS file and documents a new formal review process in CODEOWNERS changes:
New domain teams introduced:
CONTRIBUTING.md additions:
PR template update:
Type of change
How have you tested?Process and ownership files only — no runtime code changes. Verify by inspecting the CODEOWNERS diff to confirm all packages have owners and that the new team names are consistent. Checklist:
PR Bot InformationVersion:
|
![hyperspace-pr-bot[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
The PR is a well-structured overhaul of ownership and process documentation, but there are a few correctness issues to address: the section numbering jumps from A2 to A4 (missing A3), two packages referenced in A4 (cards-editor-middleware and cards-editor-config-writer) don't appear to exist in the repo, the messagebundle.properties localisation rule is missing its leading /, and the CONTRIBUTING.md introduces a duplicate "Review Process" heading. Please address these before merging.
- Add missing leading / to messagebundle.properties localisation rule - Add comment explaining A3 is intentionally absent from section numbering
heimwege
left a comment
heimwege
left a comment
There was a problem hiding this comment.
- review comments addressed
- cleanup of code owners and process description adjustments lgtm
|
6 participants
Summary
@SAP/ux-tools-*teams with 7 domain teams +@SAP/ux-tools-architectscross-cutting group@SAP/ux-tools-<domain> @SAP/ux-tools-architectsodata-vocabulariesmissing trailing slashCONTRIBUTING.mdThe 7 new GitHub org teams and
@SAP/ux-tools-architectsmust be created before this PR merges, otherwise GitHub silently ignores unknown team references. Old teams should be deleted after merge.New teams needed:
@SAP/ux-tools-foundations@SAP/ux-tools-app-generators-and-deploy@SAP/ux-tools-middlewares@SAP/ux-tools-annotations-odata@SAP/ux-tools-adp-and-editors@SAP/ux-tools-fpm-and-ui@SAP/ux-tools-mcp-and-tooling@SAP/ux-tools-architects(cross-cutting)No changeset needed
No
src/or runtime dependency changes — process and ownership files only.