feat: move salesorder sample to V2 and add V4 travel sample - #147
Merged
Conversation
- Move V4/apps/salesorder to V2/apps/salesorder (OData V2 rewrite with TypeScript) - Add V4/apps/travel sample using SAP UX mock services - Add destination.json, .npmrc, and updated .gitignore to both samples - Pin generator version to 1.24.0 across README, manifest.json, and .appGenInfo.json
🔗 Link Check ResultsThe link checker has completed. This is an optional check and will not block the PR. If broken links were found, please review them at your convenience. Last updated: Run #213 at 2026-05-07T08:14:28Z |
…der and V4 travel
…subdirectory changes
github-actions
Bot
deleted the
feature/add-v2-salesorder-v4-travel-samples
branch
May 11, 2026 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
V4/apps/salesordertoV2/apps/salesorder(OData V2 sample with TypeScript rewrite)V4/apps/travelsample using SAP UX mock servicesdestination.json,.npmrc(forcing registry.npmjs.org), and updated.gitignore(excludingnode_modulesandpackage-lock.json) to both samples1.24.0inREADME.md,webapp/manifest.json, and.appGenInfo.jsonfor both samplesTest plan
V2/apps/salesorderstarts correctly withnpm startV4/apps/travelstarts correctly withnpm startdestination.jsonproperties are correct for each sample.npmrcresolves packages fromregistry.npmjs.orgnode_modulesandpackage-lock.jsonare excluded via.gitignore