gccrs: Fix multiple glob imports in a use decl#4707
Open
powerboat9 wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Seems to pair us down to for compiling core 1.49 (not including errors detected in later phases, of course). |
Also removes some dead code in flatten, since I saw it while working on this PR and it's too small to be its own patch. gcc/rust/ChangeLog: * resolve/rust-early-name-resolver-2.0.cc (Early::resolve_glob_import): Handle glob imports that appear after other imports in a use declaration. * resolve/rust-early-name-resolver-2.0.h (Early::ImportMappings::insert): Remove member functions, as they're both broken and unused. * resolve/rust-toplevel-name-resolver-2.0.cc (flatten): Remove redundant break statement. gcc/testsuite/ChangeLog: * rust/compile/glob_import_brace.rs: New test. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also removes some dead code in flatten, since I saw it while working on this PR and it's too small to be its own patch.
Fixes #4702