Conversation
📝 WalkthroughWalkthroughThe pull request systematically updates the C++ language standard requirement from C++17 to C++20 across the entire project, including build configuration files, documentation, and formatter settings. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 632d08a in 14 seconds. Click for details.
- Reviewed
358lines of code in18files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_SO55sm7cddvuN2iY
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Description
Brief description of the changes made.
Type of Change
Testing
Platform-Specific Testing (check all that apply)
Swift SDK / iOS Sample:
Kotlin SDK / Android Sample:
Flutter SDK / Flutter Sample:
React Native SDK / React Native Sample:
Playground:
Web SDK / Web Sample:
Labels
Please add the appropriate label(s):
SDKs:
Swift SDK- Changes to Swift SDK (sdk/runanywhere-swift)Kotlin SDK- Changes to Kotlin SDK (sdk/runanywhere-kotlin)Flutter SDK- Changes to Flutter SDK (sdk/runanywhere-flutter)React Native SDK- Changes to React Native SDK (sdk/runanywhere-react-native)Web SDK- Changes to Web SDK (sdk/runanywhere-web)Commons- Changes to shared native code (sdk/runanywhere-commons)Sample Apps:
iOS Sample- Changes to iOS example app (examples/ios)Android Sample- Changes to Android example app (examples/android)Flutter Sample- Changes to Flutter example app (examples/flutter)React Native Sample- Changes to React Native example app (examples/react-native)Web Sample- Changes to Web example app (examples/web)Checklist
Screenshots
Attach relevant UI screenshots for changes (if applicable):
Important
Upgrade C++ standard from C++17 to C++20 across the project, including core, backend, and testing components, and update related documentation.
Playground/linux-voice-assistant/CMakeLists.txt,sdk/runanywhere-commons/CMakeLists.txt, andsdk/runanywhere-commons/tests/CMakeLists.txt.Standardtoc++20in.clang-format.sdk/runanywhere-commons/CLAUDE.mdandsdk/runanywhere-commons/README.md.Playground/README.mdandPlayground/linux-voice-assistant/README.md.llamacpp,onnx,rag,whispercpp, andwhisperkit_coremlto C++20.sdk/runanywhere-commons/src/jni/CMakeLists.txtandsdk/runanywhere-commons/src/server/CMakeLists.txt.This description was created by
for 632d08a. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit
Greptile Summary
This PR upgrades the C++ standard from C++17 to C++20 across the entire codebase. The upgrade is comprehensive and consistent, touching all CMakeLists.txt files, documentation, and code formatting configuration.
Key changes:
CMAKE_CXX_STANDARDandtarget_compile_featuresfrom 17/cxx_std_17to 20/cxx_std_20.clang-formatStandard fromc++17toc++20Scope:
The changes affect 18 files across the commons SDK, web SDK, and playground projects. All build configurations, tests, backends, and tools have been updated consistently.
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 632d08a