[pdf_extract]Add support for parsing pin directions#20
Open
martonmiklos wants to merge 3 commits intoRobotips:masterfrom
Open
[pdf_extract]Add support for parsing pin directions#20martonmiklos wants to merge 3 commits intoRobotips:masterfrom
martonmiklos wants to merge 3 commits intoRobotips:masterfrom
Conversation
Member
|
This is a nice functionnality, but unfortunately that broke well functional extractions. |
Contributor
Author
|
Auhc, I was not aware of the test thus I have not ran them. Let me fix them. |
Member
|
Yes I add it because with this kind of code it's easy to one thing and broke tens others ! |
Contributor
Author
2097d51 to
b124b94
Compare
Contributor
Author
|
@sebcaux please do not merge it yet. If you have a so sweet testing infrastructure in place let me add some test cases for the pin direction parsing as well. |
b124b94 to
f287ca3
Compare
Closed
f287ca3 to
99f1f25
Compare
Many datasheets present a table with the pin number, pin name and pin direction columns. This patch add support for the pin direction parsing.
99f1f25 to
40db4d5
Compare
Contributor
Author
|
Hm it looks like we have some encoding/poppler version differences between Linux (at me all tests are passing) and the appveyor Windows builds. I will investigate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Many datasheets present a table with the pin number, pin name and pin
direction columns. This patch add support for the pin direction parsing.
Tested with BQ76920 datasheet:


http://www.ti.com/lit/ds/symlink/bq76920.pdf
Example:
Result:
Note: The patch utilize some C++11 only features. If you decide not to use these features let me know in #19 and I will update/downgrade the code.