Support Decimal 3.x#105
Open
ditsbits wants to merge 2 commits into
Open
Conversation
Widen the decimal dep constraint to "~> 1.0 or ~> 2.0 or ~> 3.0". Ecto 3.14+ requires decimal ~> 3.0, which is unsolvable against the previous "~> 1.0 or ~> 2.0" constraint and blocks adoption of bitcoinex in any project on a recent Ecto. Bumps jason 1.4.0 -> 1.4.5 in mix.lock so its own decimal constraint allows resolving against decimal 3.x. Test suite passes against decimal 3.1.1 (178 tests, 0 failures). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Author
|
@SachinMeier would you be able to review? I am not able to add reviewers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widen the decimal dep constraint to "~> 1.0 or ~> 2.0 or ~> 3.0". Ecto 3.14+ requires decimal
> 3.0, which is unsolvable against the previous "> 1.0 or ~> 2.0" constraint and blocks adoption of bitcoinex in any project on a recent Ecto.Bumps jason 1.4.0 -> 1.4.5 in mix.lock so its own decimal constraint allows resolving against decimal 3.x. Test suite passes against decimal 3.1.1 (178 tests, 0 failures).