Skip to content

Rework map_selection.sample.lua#1489

Closed
maritaria wants to merge 2 commits intoRefactorio:developfrom
maritaria:patch-1
Closed

Rework map_selection.sample.lua#1489
maritaria wants to merge 2 commits intoRefactorio:developfrom
maritaria:patch-1

Conversation

@maritaria
Copy link

  • Include a list of available maps
  • Rewrite instructions

- Include a list of available maps
- Rewrite instructions
Copy link
Author

@maritaria maritaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I've not yet gone through all available options and verify that each works. I basically made a list of all generators in paths map_gen/maps/*.lua and map_gen/maps/*/preset/*.lua. Some areas are not covered like the april-fools one.

I made this PR because I think this format is a bit more noob-friendly.
Perhaps having the list of options in a giant comment for them to copy/paste would be easier for them to use than to uncomment lines, but I'll leave that up to you.

@maritaria
Copy link
Author

/rej

@maritaria maritaria closed this Mar 13, 2025
@maritaria
Copy link
Author

maritaria commented Mar 13, 2025

(closed, will reopen with similar idea).

Turns out there is something wrong with having code after top-level return.

EDIT: Lua complains about statements after top-level return. So this approach would only work if user only ever uncomments exactly one return require line. I'll rework to more closely resemble old setup but with full list of all options in the comment area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant