feat: add support for checkstyle format for scorecard-classic command#2654
Merged
AlbinaBlazhko17 merged 11 commits intomainfrom Mar 16, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 375815e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
checkstyle format for scorecard-classic command
checkstyle format for scorecard-classic commandcheckstyle format for scorecard-classic command
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
|
checkstyle format for scorecard-classic commandcheckstyle format for scorecard-classic command
JLekawa
approved these changes
Mar 13, 2026
tatomyr
reviewed
Mar 16, 2026
packages/cli/src/commands/scorecard-classic/__tests__/checkstyle-formatter.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/commands/scorecard-classic/formatters/checkstyle-formatter.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/commands/scorecard-classic/__tests__/checkstyle-formatter.test.ts
Outdated
Show resolved
Hide resolved
tatomyr
reviewed
Mar 16, 2026
| suggest: [], | ||
| location: [ | ||
| { | ||
| source: createMockSource('/api/openapi.yaml') as any, |
Collaborator
There was a problem hiding this comment.
Suggested change
| source: createMockSource('/api/openapi.yaml') as any, | |
| source: { absoluteRef: '/api/openapi.yaml') } as any, |
You can simply use this, I believe. No need for the factory function. (Same in other scorecard tests.)
Contributor
Author
There was a problem hiding this comment.
The createMockSource function is used to mock the functions, which are used inside printScorecardResultsAsCheckstyle. If i change it just to absoluteRef i will receive an error: TypeError: source.getAst is not a function.
tatomyr
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Implemented
checkstyleformat forscorecard-classiccommand.Reference
Resolves #2581
Testing
Locally
Screenshots (optional)
Check yourself
Security