Skip to content

fix: add error throw for invalid extends entries #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aim4ik11 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Draft

fix: add error throw for invalid extends entries #2615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/core/src/config/bundle-extends.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,18 @@ export function bundleExtends({
return node;
}

const invalidEntries = node.extends
.map((item, index) => ({ item, index }))
.filter(({ item }) => typeof item !== 'string');

if (invalidEntries.length > 0) {
const positions = invalidEntries.map(({ index }) => index).join(', ');
throw new Error(
`Found ${invalidEntries.length} unresolvable "extends" entr${invalidEntries.length === 1 ? 'y' : 'ies'} ` +
`at position(s) [${positions}]. Each "extends" entry must be a resolvable preset name, file path, or URL.`
);
}

const resolvedExtends = (node.extends || [])
.map((presetItem: string) => {
if (!isAbsoluteUrl(presetItem) && !path.extname(presetItem)) {
Expand Down
Loading