Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes across various transformer classes in the
rxdartpackage to improve error handling and synchronization. The main focus is on replacing asynchronous methods with synchronous counterparts to ensure better consistency and performance.Error Handling and Synchronization:
packages/rxdart/lib/src/transformers/backpressure/backpressure.dart: Replacedsink.addErrorwithsink.addErrorSyncandsink.closewithsink.closeSyncin multiple methods to improve error handling and synchronization. [1] [2] [3] [4] [5] [6]packages/rxdart/lib/src/transformers/delay.dart: Updated methods to usesink.addSyncandsink.closeSyncinstead of their asynchronous versions.packages/rxdart/lib/src/transformers/do.dart: Replacedsink.addErrorwithsink.addErrorSyncandsink.addwithsink.addSyncfor better error handling and synchronization. [1] [2] [3] [4]packages/rxdart/lib/src/transformers/exhaust_map.dart: Changed methods to usesink.addSync,sink.addErrorSync, andsink.closeSyncfor improved synchronization.packages/rxdart/lib/src/transformers/flat_map.dart: Updated to use synchronous methods for adding and closing sinks.packages/rxdart/lib/src/transformers/group_by.dart: Modified to usesink.addSyncandsink.addErrorSyncfor better error handling. [1] [2]packages/rxdart/lib/src/transformers/on_error_resume.dart: Replaced asynchronous methods with synchronous counterparts for better error handling and synchronization. [1] [2] [3]packages/rxdart/lib/src/transformers/skip_last.dart: Updated to usesink.addSyncandsink.closeSyncfor improved synchronization.packages/rxdart/lib/src/transformers/skip_until.dart: Changed methods to use synchronous versions for better error handling and synchronization. [1] [2]packages/rxdart/lib/src/transformers/start_with.dart: Updated to usesink.addSyncandsink.closeSyncfor better synchronization. [1] [2]packages/rxdart/lib/src/transformers/start_with_error.dart: Replaced asynchronous methods with synchronous ones for better error handling and synchronization.packages/rxdart/lib/src/transformers/start_with_many.dart: Changed to usesink.addSyncandsink.closeSyncfor improved synchronization.packages/rxdart/lib/src/transformers/switch_if_empty.dart: Updated methods to use synchronous versions for better error handling and synchronization.packages/rxdart/lib/src/transformers/switch_map.dart: Replacedsink.addErrorwithsink.addErrorSyncfor improved error handling.