Skip to content

Add os_signpost instrumentation for scan phases#81

Merged
RasputinKaiser merged 1 commit into
mainfrom
codex/signpost-instrumentation
Jun 22, 2026
Merged

Add os_signpost instrumentation for scan phases#81
RasputinKaiser merged 1 commit into
mainfrom
codex/signpost-instrumentation

Conversation

@RasputinKaiser

Copy link
Copy Markdown
Owner

Summary

  • Purely additive os_signpost spans for Instruments profiling of scan-side work. No behavioral changes; emits begin/end intervals that are no-ops when no profiler is attached.
  • FileSystemScanner: top-level scan span wraps the whole scan, enumerate wraps each concurrentPerform child iteration, verify wraps each duplicate-hash verification group iteration.
  • ScanStore: persist wraps the post-scan hashCache.persist() call (in the detached utility task).
  • FilterStore: index wraps rebuildSearchSubtreeMatchIDs.
  • Shared OSLog(subsystem: "com.rasputinkaiser.StorageScope", category: "scan") across all three classes so spans cluster in the Instruments timeline.

Validation

  • swift test — 54/54 passing
  • ./script/public_upload_audit.sh — passed
  • bash ./script/build_and_run.sh --verify — app bundle signature and launch verified

Privacy And Safety

  • No signing files, provisioning profiles, app bundles, DMGs, packages, scan outputs, Codex state, or local-only handoff docs are committed.
  • No new file access, cleanup, duplicate detection, or local data handling. Signpost spans emit no PII — %{public}@ paths are local file names only and never written to disk by StorageScope.

Purely additive os_signpost spans for Instruments profiling of scan-side
work. No behavioral changes; emits begin/end intervals that are no-ops
when no profiler is attached.

- FileSystemScanner: top-level "scan" span wraps the scan, "enumerate"
  wraps each concurrentPerform child iteration, "verify" wraps each
  duplicate-hash verification group.
- ScanStore: "persist" wraps the post-scan hashCache.persist() call.
- FilterStore: "index" wraps rebuildSearchSubtreeMatchIDs.

Subsystem com.rasputinkaiser.StorageScope / category scan mirroring
across all three classes so spans cluster in the Instruments timeline.

Co-Authored-By: NCode <noreply@noumena.com>
@RasputinKaiser RasputinKaiser merged commit eded991 into main Jun 22, 2026
6 checks passed
@RasputinKaiser RasputinKaiser deleted the codex/signpost-instrumentation branch June 22, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant