fix: allow menu shortcut to override existing one#792
Merged
maribethb merged 1 commit intoRaspberryPiFoundation:mainfrom Mar 31, 2026
Merged
fix: allow menu shortcut to override existing one#792maribethb merged 1 commit intoRaspberryPiFoundation:mainfrom
maribethb merged 1 commit intoRaspberryPiFoundation:mainfrom
Conversation
gonfunko
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes RaspberryPiFoundation/blockly#9652
Allows the menu shortcut in the plugin to override any in core if present, making the plugin compatible with v12.5+ of blockly
Since the menu shortcut here will return true if the menu is actually opened, this will tell the shortcut system that it has been "handled" and thus the one in core will not fire
Updates the dev version of Blockly to 12.5.1 to test compatibility with latest