Fix Message.edit() ignoring global allowed mentions#10406
Fix Message.edit() ignoring global allowed mentions#10406Soheab wants to merge 1 commit intoRapptz:masterfrom
Conversation
|
I'm not big on this change. Now the library is always sending this field during a PATCH operation which is not how it's supposed to be done. |
|
I honestly agree with @Rapptz , the implementation does fix the mentioned issue. BUT, it comes at the aforementioned cost. I took an hour or two of my day to analyze the logic aaaand, the bug itself is actually easy to fix! When The proper fix is to gate on |
|
This is something Discord should fix, as mentioning in an edit call, like users, does not notify the users. For bots, it for some reason does show the yellow background as if it did succeed, but it didn't. AFAIK |
Summary
This PR fixes an issue where the allowed mentions configured on the bot did not apply when editing a message via
(Partial)Message.edit(). As a result, the edit would still ping users etc even when mentions were explicitly disabled, forcing users to reapply the allowed mentions manually.From what I can tell, this behavior only happens in
(Partial)Message.edit().Related help post: https://canary.discord.com/channels/336642139381301249/1475259678702440580
Checklist