gfx1200 memory limits milestone3-babel (#1671) - #1698
Merged
Conversation
ronlieb
commented
Nov 22, 2025
ronlieb
commented
Contributor
swdev-565113 Please enter the commit message for your changes. Lines starting
carlobertolli
approved these changes
Nov 23, 2025
carlobertolli
left a comment
carlobertolli
left a comment
Contributor
There was a problem hiding this comment.
Small nits can be fixed post merge
| save_status | ||
| ./milestone-3-babel -n 20 -s 100000000 # 2400.0 MB | ||
| save_status | ||
| if [[ "$AOMP_GPU" =~ ^gfx12.* ]]; then |
Contributor
There was a problem hiding this comment.
I would limit it to gfx1200 and gfx1201
|
|
||
| $PRECMD ./milestone-3-babel -n 20 -s 100000000 # 2400.0 MB | ||
| save_status | ||
| if [[ "$AOMP_GPU" =~ ^gfx12.* ]]; then |
|
re-running test seems infra issue - http://rocm-ci.amd.com/job/rocm-tests/34924/ |
dpalermo
approved these changes
Dec 1, 2025
|
Landing this as PSDB rocm-ci failures are unrelated, as this is a fortran update. Failures in rocgdb, ocl, rocprof are irrelevant |
nicebert
added a commit
that referenced
this pull request
Mar 10, 2026
Update 27 tests (19 smoke, 8 smoke-limbo) to use replacement flags for specialized kernel generation. The -fopenmp-target-ignore-env-vars flag is removed from ROCm/llvm-project (PR #1698) as it had no codegen implementation and represented a deprecated approach. Replaced with -fopenmp-assume-teams-oversubscription and -fopenmp-assume-threads-oversubscription, which provide equivalent functionality by indicating that the runtime can ignore environment variables for thread/team configuration, enabling no-loop and xteam-reduction kernel optimizations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.