fix: reduce verbose test output by veksen · Pull Request #54 · Query-Doctor/analyzer

veksen · 2026-02-17T21:22:52Z

Summary

Remove redundant console.error() calls in remote.ts, query-loader.ts, and pg-connector.ts that dump full stack traces after log.error() already captures the message
Suppress PostgreSQL NOTICE messages (e.g. database "optimizing_db" does not exist, skipping from DROP DATABASE IF EXISTS) by adding a notice handler on pool connections in postgresjs.ts

Context

CI test output (e.g. run 21953367938) is very noisy with repeated ConnectionRefused stack traces and PG NOTICE dumps that obscure actual test results.

Test plan

CI tests pass with reduced output noise
Verify errors are still logged via log.error() (just no duplicate console.error stack dumps)

🤖 Generated with Claude Code

Remove redundant console.error() calls that dump full stack traces when log.error() already captures the message. Suppress PostgreSQL NOTICE messages (e.g. DROP DATABASE IF EXISTS on non-existent db) by adding a notice handler to the connection pool. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

github-actions

Found New Recommended Indexes

The following indexes are likely to make the most impact to your queries. They're ordered by how many queries seen in your tests

Index Definition	Usage Count
`assets(event_id, uploader_id, inserted_at desc)`	1
`guest_ip_addresses(ip_address)`	1

Statistics Mode

When generating recommendations, we made the following changes to your database statistics:

fixed rows per table

Rows per table: 10000
Pages per table: 1

Instead of assuming a fixed number of rows per table (which can cause unnecessary recommendations), you can export statistics from your production database and import it using the STATISTICS_PATH environment variable. You can read more about how to sync stats here.

- name: Analyze
  uses: query-doctor/analyzer@v0
  env:
    STATISTICS_PATH: ./statistics.json

Optimization Overview

Query	Base Cost	Optimized Cost	Improvement
3527900520088515000	15922.03	1638.53	9.72x
7119592456364862000	126	9.04	13.94x

Query 3527900520088515000

New indexes improve cost by 9.72x:

assets(event_id, uploader_id, inserted_at desc)

View Query (too long to display inline)

SELECT
  "guests"."id",
  "guests"."session_id",
  "guests"."username",
  "guests"."avatar_path",
  "guests"."color",
  "guests"."side",
  "guests"."audio_recording_path",
  "guests"."audio_recording_public",
  "guests"."memo",
  "guests"."memo_public",
  "guests"."setup_at",
  "guests"."last_upload",
  "guests"."inserted_at",
  "guests"."updated_at",
  "userAssets"."id",
  "userAssets"."kind",
  "userAssets"."event_id",
  "userAssets"."uploader_id",
  "userAssets"."uploader_ip",
  "userAssets"."path",
  "userAssets"."file_size",
  "userAssets"."width",
  "userAssets"."height",
  "userAssets"."visible_at",
  "userAssets"."deleted_at",
  "userAssets"."inserted_at",
  "userAssets"."updated_at"
FROM
  (
    SELECT
      "id",
      "session_id",
      "username",
      "avatar_path",
      "color",
      "side",
      "audio_recording_path",
      "audio_recording_public",
      "memo",
      "memo_public",
      "setup_at",
      "last_upload",
      "inserted_at",
      "updated_at"
    FROM
      "guests"
    ORDER BY
      "guests"."last_upload" DESC,
      "guests"."id" DESC
    LIMIT
      100
  ) "guests"
  CROSS JOIN LATERAL (
    SELECT
      "id",
      "kind",
      "event_id",
      "uploader_id",
      "uploader_ip",
      "path",
      "file_size",
      "width",
      "height",
      "visible_at",
      "deleted_at",
      "inserted_at",
      "updated_at"
    FROM
      "assets"
    WHERE
      (
        "assets"."event_id" = (
          SELECT
            "id"
          FROM
            "events"
          WHERE
            "events"."event_key" = '01JKCVP4M2CH34SVTQGHSW4Y5G'
        )
        AND "assets"."uploader_id" = "guests"."id"
      )
    ORDER BY
      "assets"."inserted_at" DESC
    LIMIT
      100
  ) "userAssets";

View Explain Plan (before optimization)

{
  "Node Type": "Nested Loop",
  "Parallel Aware": false,
  "Async Capable": false,
  "Join Type": "Inner",
  "Startup Cost": 159.35,
  "Total Cost": 15922.03,
  "Plan Rows": 100,
  "Plan Width": 370,
  "Inner Unique": false,
  "Plans": [
    {
      "Node Type": "Limit",
      "Parent Relationship": "Outer",
      "Parallel Aware": false,
      "Async Capable": false,
      "Startup Cost": 0.16,
      "Total Cost": 1.78,
      "Plan Rows": 100,
      "Plan Width": 238,
      "Plans": [
        {
          "Node Type": "Index Scan",
          "Parent Relationship": "Outer",
          "Parallel Aware": false,
          "Async Capable": false,
          "Scan Direction": "Forward",
          "Index Name": "guests_last_upload_desc_id_desc_index",
          "Relation Name": "guests",
          "Alias": "guests",
          "Startup Cost": 0.16,
          "Total Cost": 162.16,
          "Plan Rows": 10000,
          "Plan Width": 238
        }
      ]
    },
    {
      "Node Type": "Limit",
      "Parent Relationship": "Inner",
      "Parallel Aware": false,
      "Async Capable": false,
      "Startup Cost": 159.19,
      "Total Cost": 159.19,
      "Plan Rows": 1,
      "Plan Width": 132,
      "Plans": [
        {
          "Node Type": "Index Scan",
          "Parent Relationship": "InitPlan",
          "Subplan Name": "InitPlan 1 (returns $0)",
          "Parallel Aware": false,
          "Async Capable": false,
          "Scan Direction": "Forward",
          "Index Name": "events_event_key_index",
          "Relation Name": "events",
          "Alias": "events",
          "Startup Cost": 0.16,
          "Total Cost": 8.18,
          "Plan Rows": 1,
          "Plan Width": 8,
          "Index Cond": "(event_key = '01JKCVP4M2CH34SVTQGHSW4Y5G'::text)"
        },
        {
          "Node Type": "Sort",
          "Parent Relationship": "Outer",
          "Parallel Aware": false,
          "Async Capable": false,
          "Startup Cost": 151.01,
          "Total Cost": 151.01,
          "Plan Rows": 1,
          "Plan Width": 132,
          "Sort Key": [
            "assets.inserted_at DESC"
          ],
          "Plans": [
            {
              "Node Type": "Seq Scan",
              "Parent Relationship": "Outer",
              "Parallel Aware": false,
              "Async Capable": false,
              "Relation Name": "assets",
              "Alias": "assets",
              "Startup Cost": 0,
              "Total Cost": 151,
              "Plan Rows": 1,
              "Plan Width": 132,
              "Filter": "((event_id = $0) AND (uploader_id = guests.id))"
            }
          ]
        }
      ]
    }
  ]
}

View Explain Plan (after optimization)

{
  "Node Type": "Nested Loop",
  "Parallel Aware": false,
  "Async Capable": false,
  "Join Type": "Inner",
  "Startup Cost": 8.5,
  "Total Cost": 1638.53,
  "Plan Rows": 100,
  "Plan Width": 370,
  "Inner Unique": false,
  "Plans": [
    {
      "Node Type": "Limit",
      "Parent Relationship": "Outer",
      "Parallel Aware": false,
      "Async Capable": false,
      "Startup Cost": 0.16,
      "Total Cost": 1.78,
      "Plan Rows": 100,
      "Plan Width": 238,
      "Plans": [
        {
          "Node Type": "Index Scan",
          "Parent Relationship": "Outer",
          "Parallel Aware": false,
          "Async Capable": false,
          "Scan Direction": "Forward",
          "Index Name": "guests_last_upload_desc_id_desc_index",
          "Relation Name": "guests",
          "Alias": "guests",
          "Startup Cost": 0.16,
          "Total Cost": 162.16,
          "Plan Rows": 10000,
          "Plan Width": 238
        }
      ]
    },
    {
      "Node Type": "Limit",
      "Parent Relationship": "Inner",
      "Parallel Aware": false,
      "Async Capable": false,
      "Startup Cost": 8.34,
      "Total Cost": 16.36,
      "Plan Rows": 1,
      "Plan Width": 132,
      "Plans": [
        {
          "Node Type": "Index Scan",
          "Parent Relationship": "InitPlan",
          "Subplan Name": "InitPlan 1 (returns $0)",
          "Parallel Aware": false,
          "Async Capable": false,
          "Scan Direction": "Forward",
          "Index Name": "events_event_key_index",
          "Relation Name": "events",
          "Alias": "events",
          "Startup Cost": 0.16,
          "Total Cost": 8.18,
          "Plan Rows": 1,
          "Plan Width": 8,
          "Index Cond": "(event_key = '01JKCVP4M2CH34SVTQGHSW4Y5G'::text)"
        },
        {
          "Node Type": "Index Scan",
          "Parent Relationship": "Outer",
          "Parallel Aware": false,
          "Async Capable": false,
          "Scan Direction": "Forward",
          "Index Name": "assets(event_id, uploader_id, inserted_at desc)",
          "Relation Name": "assets",
          "Alias": "assets",
          "Startup Cost": 0.16,
          "Total Cost": 8.18,
          "Plan Rows": 1,
          "Plan Width": 132,
          "Index Cond": "((event_id = $0) AND (uploader_id = guests.id))"
        }
      ]
    }
  ]
}

Query 7119592456364862000

New indexes improve cost by 13.94x:

guest_ip_addresses(ip_address)

SELECT
  *
FROM
  guest_ip_addresses
WHERE
  ip_address = '127.0.0.1';

View Explain Plan (before optimization)

{
  "Node Type": "Seq Scan",
  "Parallel Aware": false,
  "Async Capable": false,
  "Relation Name": "guest_ip_addresses",
  "Alias": "guest_ip_addresses",
  "Startup Cost": 0,
  "Total Cost": 126,
  "Plan Rows": 50,
  "Plan Width": 56,
  "Filter": "(ip_address = '127.0.0.1'::text)"
}

View Explain Plan (after optimization)

{
  "Node Type": "Index Scan",
  "Parallel Aware": false,
  "Async Capable": false,
  "Scan Direction": "Forward",
  "Index Name": "guest_ip_addresses(ip_address)",
  "Relation Name": "guest_ip_addresses",
  "Alias": "guest_ip_addresses",
  "Startup Cost": 0.16,
  "Total Cost": 9.04,
  "Plan Rows": 50,
  "Plan Width": 56,
  "Index Cond": "(ip_address = '127.0.0.1'::text)"
}

What are the numbers next to the query?

The numbers are a fingerprint uniquely identifying the query. Let us know in the Discord if you'd like to be able to assign unique names to your queries.

What is cost?

Cost is an arbitrary value representing the amount of work postgres decided it needs to do to execute a query based on what it knows about the database and the query itself.
We use cost to look for improvements when checking if an index helps optimize a query in CI as the full production dataset is simply not available to work with.

Execution metadata

Log size: 212123 bytes
Time elapsed: 2310ms
Queries Seen: 28
Queries matched: 10
Queries optimized: 2
Queries errored: 1

Xetera

I don't love these changes because these logs are genuinely useful but I guess sometimes cause problems at the end of tests.

Can we implement something with an abort controller or an abort signal check to conditionally silence these? Because we're losing actual error logging here just to make tests less annoying

veksen · 2026-02-17T22:02:13Z

Yeah I also wasn't sure about them, perhaps mocking console in tests?

github-actions bot reviewed Feb 17, 2026

View reviewed changes

Xetera requested changes Feb 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: reduce verbose test output#54

fix: reduce verbose test output#54
veksen wants to merge 1 commit intomainfrom
veksen/quiet-test-logs

veksen commented Feb 17, 2026

Uh oh!

github-actions bot left a comment

Uh oh!

Xetera left a comment •

edited

Loading

Uh oh!

veksen commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

veksen commented Feb 17, 2026

Summary

Context

Test plan

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Found New Recommended Indexes

Statistics Mode

Optimization Overview

Query 3527900520088515000

Query 7119592456364862000

Uh oh!

Xetera left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

veksen commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Xetera left a comment •

edited

Loading