Skip to content

[codex] add CI workflow lint and whitespace checks#36

Merged
Pigbibi merged 3 commits into
mainfrom
codex/ci-gates-20260702
Jul 2, 2026
Merged

[codex] add CI workflow lint and whitespace checks#36
Pigbibi merged 3 commits into
mainfrom
codex/ci-gates-20260702

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add an actionlint job to CI.
  • Add git whitespace checking before Python setup.

Validation

  • actionlint
  • git diff --check
  • temporary venv CI mirror: pip check, ruff check, pytest -q, python -m build

Pigbibi and others added 2 commits July 2, 2026 17:26
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: efced0e114

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
set -euo pipefail
if [ "${{ github.event_name }}" = "pull_request" ]; then
git fetch --no-tags --depth=1 origin "${{ github.base_ref }}"
git diff --check "origin/${{ github.base_ref }}...HEAD"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Fetch enough history before triple-dot diff

On pull_request runs this uses origin/${{ github.base_ref }}...HEAD, but the preceding checkout still has the default shallow history: the checkout README documents fetch-depth defaulting to 1, and Git documents A...B as diffing from merge-base A B. In that shallow PR checkout Git cannot find the merge base even after fetching the base tip, so this step exits with fatal: ... no merge base and blocks the CI before tests run. Set fetch-depth: 0/fetch the merge base, or diff against an explicitly fetched base SHA.

Useful? React with 👍 / 👎.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi Pigbibi merged commit 6c10aef into main Jul 2, 2026
3 checks passed
@Pigbibi Pigbibi deleted the codex/ci-gates-20260702 branch July 2, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant