Skip to content

chore: tighten HK low-vol snapshot artifact upload guards #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jul 3, 2026
Merged

chore: tighten HK low-vol snapshot artifact upload guards #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-hk-low-vol-snapshot-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ jobs:
with:
name: ${{ steps.build.outputs.artifact_name }}
path: ${{ steps.build.outputs.artifact_dir }}
if-no-files-found: ignore
if-no-files-found: error
retention-days: 14

- name: Upload generated input snapshot
Expand All @@ -363,7 +363,7 @@ jobs:
with:
name: ${{ steps.build.outputs.generated_input_name }}
path: ${{ steps.build.outputs.generated_input_dir }}
if-no-files-found: ignore
if-no-files-found: error
retention-days: 14

- name: Append job summary
Expand Down
2 changes: 1 addition & 1 deletion tests/test_build_hk_low_vol_snapshot_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ def test_hk_low_vol_snapshot_artifact_workflow_keeps_generation_diagnostics():
assert "failed_symbols_preview" in workflow
assert '${generation_label} factor snapshot generation failed; see generation_summary.json' in workflow
assert "if: always() && steps.build.outputs.generated_input_name != ''" in workflow
assert "if-no-files-found: ignore" in workflow
assert "if-no-files-found: error" in workflow
Loading