chore: update strategy dependency pins#290
Conversation
Co-Authored-By: Codex <noreply@openai.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4104e5b99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@46887bc3f5454d5b59623b1f5efb7c65912c6b8b | ||
| hk-equity-strategies @ git+https://github.com/QuantStrategyLab/HkEquityStrategies.git@61993bf261aeccf64b5a75428b9405f4e1d1d682 |
There was a problem hiding this comment.
Because Dockerfile line 16 installs requirements.txt with -c constraints.txt, these new direct-URL pins are still constrained by constraints.txt lines 7-8 to the old 64342a... and 3746fa... strategy commits. Pip rejects a requirement when the same package is constrained to a different direct URL, so Docker/Cloud Run dependency installation continues to fail on this deploy path unless the constraints file is updated in the same change or no longer applied to these git packages.
Useful? React with 👍 / 👎.
Co-Authored-By: Codex <noreply@openai.com>
1 participant
Summary\n- update strategy package pins to versions that depend on QPK 0063af3\n- fixes deploy pip conflict between platform QPK pin and strategy package QPK pin\n\n## Tests\n- python3.11 scripts/check_qpk_pin_consistency.py