Fix runtime settings defaults#285
Conversation
Co-Authored-By: Codex <noreply@openai.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0af63160d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "us_equity_combo", | ||
| "us_equity_combo_leveraged", |
There was a problem hiding this comment.
Gate combo profiles until their inputs are wired
Adding these combo profiles to the supported LongBridge set makes them appear in the status/sync flows, but the runtime adapter path still cannot supply their required inputs: us_equity_combo requires russell_snapshot and current_holdings, and us_equity_combo_leveraged requires market_data, while application/runtime_strategy_adapters.py only materializes market/benchmark/QQQ history, derived indicators, portfolio snapshots, and account state before calling build_strategy_evaluation_inputs. In any Cloud Run target selecting either combo profile, evaluation will be invoked without the required inputs and fail before producing a rebalance plan, so these should stay gated or the missing input plumbing should be added first.
Useful? React with 👍 / 👎.
Summary
Test Plan