Skip to content

Fix runtime settings defaults#285

Merged
Pigbibi merged 1 commit into
mainfrom
codex/settings-switch-runtime-20260702
Jul 2, 2026
Merged

Fix runtime settings defaults#285
Pigbibi merged 1 commit into
mainfrom
codex/settings-switch-runtime-20260702

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve runtime target enabled default when env flag is omitted.
  • Keep optional runtime booleans nullable and update supported profile expectations.
  • Add missing combo strategy translations for notifications.

Test Plan

  • python3 -m pytest tests/test_runtime_config_support.py tests/test_notifications.py tests/test_dependency_pins.py -q && git diff --check

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi Pigbibi merged commit 5831336 into main Jul 2, 2026
2 checks passed
@Pigbibi Pigbibi deleted the codex/settings-switch-runtime-20260702 branch July 2, 2026 08:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0af63160d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +65 to +66
"us_equity_combo",
"us_equity_combo_leveraged",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Gate combo profiles until their inputs are wired

Adding these combo profiles to the supported LongBridge set makes them appear in the status/sync flows, but the runtime adapter path still cannot supply their required inputs: us_equity_combo requires russell_snapshot and current_holdings, and us_equity_combo_leveraged requires market_data, while application/runtime_strategy_adapters.py only materializes market/benchmark/QQQ history, derived indicators, portfolio snapshots, and account state before calling build_strategy_evaluation_inputs. In any Cloud Run target selecting either combo profile, evaluation will be invoked without the required inputs and fail before producing a rebalance plan, so these should stay gated or the missing input plumbing should be added first.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant