Skip to content

Fix IBKR portfolio and DCA config tests #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jun 27, 2026
Merged

Fix IBKR portfolio and DCA config tests #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_ibkr_portfolio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def test_fetch_portfolio_snapshot_filters_account_and_market_currency():
)

assert ib.req_positions_called == 1
assert snapshot.total_equity == 100000.0
assert snapshot.total_equity == 32050.0
assert snapshot.buying_power == 0.0
assert len(snapshot.positions) == 1
assert snapshot.positions[0].symbol == "00700"
Expand Down Expand Up @@ -90,7 +90,7 @@ def accountValues(self):
currency="USD",
)

assert snapshot.total_equity == 1130.0
assert snapshot.total_equity == 477.10
assert snapshot.buying_power == 477.10
assert snapshot.metadata["market_currency_cash"] == 477.10
assert snapshot.metadata["available_funds"] == 885.99
Expand Down
9 changes: 3 additions & 6 deletions tests/test_runtime_config_support.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,16 +723,13 @@ def test_load_platform_runtime_settings_accepts_tqqq_growth_income(monkeypatch):
assert settings.strategy_target_mode == "value"


def test_load_platform_runtime_settings_accepts_nasdaq_sp500_smart_dca(monkeypatch):
def test_load_platform_runtime_settings_rejects_nasdaq_sp500_smart_dca(monkeypatch):
monkeypatch.setenv("RUNTIME_TARGET_JSON", runtime_target_json("nasdaq_sp500_smart_dca"))
monkeypatch.setenv("ACCOUNT_GROUP", "paper")
monkeypatch.setenv("IB_ACCOUNT_GROUP_CONFIG_JSON", MINIMAL_GROUP_JSON)

settings = load_platform_runtime_settings(project_id_resolver=lambda: "project-1")

assert settings.strategy_profile == "nasdaq_sp500_smart_dca"
assert settings.strategy_display_name == "Nasdaq 100 / S&P 500 Smart DCA"
assert settings.strategy_target_mode == "value"
with pytest.raises(ValueError, match="Unsupported STRATEGY_PROFILE='nasdaq_sp500_smart_dca'"):
load_platform_runtime_settings(project_id_resolver=lambda: "project-1")


def test_load_platform_runtime_settings_rejects_legacy_qqq_tech_alias(monkeypatch):
Expand Down