chore: align QSL bundle pins#240
Conversation
Co-Authored-By: Codex <noreply@openai.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7daf4a995
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@0063af3b4a974650ea58a7d3f26dd1b94f65d3e8", | ||
| "us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@46887bc3f5454d5b59623b1f5efb7c65912c6b8b", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@7032cde4547e7ec59af15df8935d142461a77051", | ||
| "us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@9f0e5e2deca8a9c16d711eb4772f08a7901da101", |
There was a problem hiding this comment.
Choose a strategy ref with the same QPK pin
The UsEquityStrategies@9f0e5e2... commit selected here still declares quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@0063af3... in its pyproject, but this change pairs it with the root quant-platform-kit pin at 7032cde.... When these inputs are resolved from pyproject.toml (for example, regenerating uv.lock or doing a non-frozen install), uv treats the two direct Git URLs for quant-platform-kit as conflicting, so the bundle cannot be reproduced cleanly. Please update the strategy ref to one that depends on the same QPK commit, or keep the root QPK pin aligned with the strategy metadata.
Useful? React with 👍 / 👎.
| "numpy", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@0063af3b4a974650ea58a7d3f26dd1b94f65d3e8", | ||
| "us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@46887bc3f5454d5b59623b1f5efb7c65912c6b8b", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@7032cde4547e7ec59af15df8935d142461a77051", |
There was a problem hiding this comment.
Keep the QPK dependency on the canonical pin
The CI workflow's Check QPK pin consistency step runs scripts/check_qpk_pin_consistency.py, which fetches QuantPlatformKit/main/QPK_PIN; that canonical file currently contains 0063af3..., while this line now pins 7032cde.... In CI environments that can reach GitHub, the guard reports a QPK mismatch and exits non-zero, so this change blocks the required checks before tests finish. Pin this dependency to the QPK_PIN value, or update the canonical pin first.
Useful? React with 👍 / 👎.
Co-Authored-By: Codex <noreply@openai.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1adb8cc84d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "numpy", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@0063af3b4a974650ea58a7d3f26dd1b94f65d3e8", | ||
| "us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@46887bc3f5454d5b59623b1f5efb7c65912c6b8b", | ||
| "quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@37c81901160c5b31127a27dba1c63944933fb6bf", |
There was a problem hiding this comment.
Keep the QPK dependency on the canonical pin
Fresh evidence: the updated dependency now pins 37c8190..., while the current QuantPlatformKit/main/QPK_PIN still contains 0063af3...; the CI workflow's Check QPK pin consistency step runs scripts/check_qpk_pin_consistency.py, which fetches that canonical pin and exits non-zero for any QuantPlatformKit.git@... ref that differs. In CI environments with GitHub access, this changed line therefore blocks the required check before the PR can pass.
Useful? React with 👍 / 👎.
|
|
||
| [qsl.compat] | ||
| bundle = "2026.07.1" | ||
| bundle = "2026.07.2" |
There was a problem hiding this comment.
Update the QSL metadata test with the bundle bump
When this bundle value is changed to 2026.07.2, python -m pytest tests/test_qsl_metadata.py -q now fails because tests/test_qsl_metadata.py::test_qsl_metadata_has_runtime_platform_fields still asserts qsl["compat"]["bundle"] == "2026.07.0". Any developer or CI path that runs the test suite will see this regression until the test is updated alongside the metadata bump.
Useful? React with 👍 / 👎.
Summary
Validation