Skip to content

chore: align QSL bundle pins#240

Merged
Pigbibi merged 2 commits into
mainfrom
codex/qsl-align-bundle-2026071
Jul 4, 2026
Merged

chore: align QSL bundle pins#240
Pigbibi merged 2 commits into
mainfrom
codex/qsl-align-bundle-2026071

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • align this repository with QSL bundle 2026.07.1
  • update internal git dependency pins only; no business logic changes

Validation

  • git diff --check
  • QuantRuntimeSettings scripts/check_qsl_compat.py reports ok=true for this repo
  • QuantRuntimeSettings qslctl report reports 0 strict / 0 warnings across 25 local Quant repos

Co-Authored-By: Codex <noreply@openai.com>
@cursor

cursor Bot commented Jul 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7daf4a995

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pyproject.toml Outdated
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@0063af3b4a974650ea58a7d3f26dd1b94f65d3e8",
"us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@46887bc3f5454d5b59623b1f5efb7c65912c6b8b",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@7032cde4547e7ec59af15df8935d142461a77051",
"us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@9f0e5e2deca8a9c16d711eb4772f08a7901da101",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Choose a strategy ref with the same QPK pin

The UsEquityStrategies@9f0e5e2... commit selected here still declares quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@0063af3... in its pyproject, but this change pairs it with the root quant-platform-kit pin at 7032cde.... When these inputs are resolved from pyproject.toml (for example, regenerating uv.lock or doing a non-frozen install), uv treats the two direct Git URLs for quant-platform-kit as conflicting, so the bundle cannot be reproduced cleanly. Please update the strategy ref to one that depends on the same QPK commit, or keep the root QPK pin aligned with the strategy metadata.

Useful? React with 👍 / 👎.

Comment thread pyproject.toml Outdated
"numpy",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@0063af3b4a974650ea58a7d3f26dd1b94f65d3e8",
"us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@46887bc3f5454d5b59623b1f5efb7c65912c6b8b",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@7032cde4547e7ec59af15df8935d142461a77051",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the QPK dependency on the canonical pin

The CI workflow's Check QPK pin consistency step runs scripts/check_qpk_pin_consistency.py, which fetches QuantPlatformKit/main/QPK_PIN; that canonical file currently contains 0063af3..., while this line now pins 7032cde.... In CI environments that can reach GitHub, the guard reports a QPK mismatch and exits non-zero, so this change blocks the required checks before tests finish. Pin this dependency to the QPK_PIN value, or update the canonical pin first.

Useful? React with 👍 / 👎.

Co-Authored-By: Codex <noreply@openai.com>
@cursor

cursor Bot commented Jul 4, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1adb8cc84d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread pyproject.toml
"numpy",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@0063af3b4a974650ea58a7d3f26dd1b94f65d3e8",
"us-equity-strategies @ git+https://github.com/QuantStrategyLab/UsEquityStrategies.git@46887bc3f5454d5b59623b1f5efb7c65912c6b8b",
"quant-platform-kit @ git+https://github.com/QuantStrategyLab/QuantPlatformKit.git@37c81901160c5b31127a27dba1c63944933fb6bf",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the QPK dependency on the canonical pin

Fresh evidence: the updated dependency now pins 37c8190..., while the current QuantPlatformKit/main/QPK_PIN still contains 0063af3...; the CI workflow's Check QPK pin consistency step runs scripts/check_qpk_pin_consistency.py, which fetches that canonical pin and exits non-zero for any QuantPlatformKit.git@... ref that differs. In CI environments with GitHub access, this changed line therefore blocks the required check before the PR can pass.

Useful? React with 👍 / 👎.

Comment thread qsl.toml

[qsl.compat]
bundle = "2026.07.1"
bundle = "2026.07.2"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the QSL metadata test with the bundle bump

When this bundle value is changed to 2026.07.2, python -m pytest tests/test_qsl_metadata.py -q now fails because tests/test_qsl_metadata.py::test_qsl_metadata_has_runtime_platform_fields still asserts qsl["compat"]["bundle"] == "2026.07.0". Any developer or CI path that runs the test suite will see this regression until the test is updated alongside the metadata bump.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit c5f659e into main Jul 4, 2026
5 checks passed
@Pigbibi Pigbibi deleted the codex/qsl-align-bundle-2026071 branch July 4, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant