fix: restore get_firestore_client & get_state_doc_ref, align cloud param names#78
Merged
Merged
Conversation
…s, align param names - Add back get_firestore_client() wrapping DocumentStore.client (GcpDocumentStore) - Add back get_state_doc_ref() using the Firestore client - Keep _get_document_store() for internal use in load/save_trade_state - Rename gcs_prefix_uri → cloud_prefix_uri, gcp_project_id → project_id in cycle_service Fixes ImportError in trend_pool_support.py → live_services import chain. Co-Authored-By: Claude <noreply@anthropic.com>
Pigbibi
force-pushed
the
fix/live-services-import-error
branch
from
85206f8 to
da0f31d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
ImportError: cannot import name 'get_firestore_client' from 'live_services'that broke Runtime workflow #3208.Root Cause
Refactoring of
live_services.pyremovedget_firestore_clientandget_state_doc_refin favor of_get_document_store(), buttrend_pool_support.pyandmain.pystill import those functions.Changes
get_firestore_client()wrappingDocumentStore.client(GcpDocumentStore)get_state_doc_ref()using the Firestore clientgcs_prefix_uri→cloud_prefix_uri,gcp_project_id→project_idincycle_service.pyVerification
from live_services import get_firestore_client, get_state_doc_ref✅from trend_pool_support import infer_base_asset✅ (full import chain)🤖 Generated with Claude Code