Use pyicu-wheels for tests via PEP 735 dependency groups; remove redundant optional-deps#1337
Draft
Use pyicu-wheels for tests via PEP 735 dependency groups; remove redundant optional-deps#1337
Conversation
- Add [dependency-groups] section to pyproject.toml with test groups
(test-core, test-compact, test-extra, test-noauto-{torch,tensorflow,
onnx,cython,network}, test-corpus) using pyicu-wheels for pre-built
ICU wheels instead of pyicu
- Simplify unittest.yml by removing macOS brew install icu4c step and
Windows PyICU wheel download step; use pip install --group instead
- Update tests/README.md to document the new dependency groups approach
- Update CHANGELOG.md
Co-authored-by: bact <128572+bact@users.noreply.github.com>
…roups - Remove dev, docs, compact, extra, noauto-*, full from [project.optional-dependencies] - Add dev, docs, test-full to [dependency-groups]; test-full uses pyicu-wheels instead of pyicu - Update deploy-docs.yml and pypi-test.yml to use pip install --group - Update tests/README.md to use only PEP 735 syntax - Update CHANGELOG.md Co-authored-by: bact <128572+bact@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Use pyicu-wheels for tests in project
Use pyicu-wheels for tests via PEP 735 dependency groups; remove redundant optional-deps
Mar 14, 2026
|
Member
|
pyicu-wheels does not provide a wheel for Python 3.9 on Windows. But Python 3.9 is EOL and PyThaiNLP 6.0.0 may move to Python 3.10, so it is possible to proceed at that point. Keep this PR open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Installing
pyicufor testing required compiling ICU from source on macOS (via Homebrew) and downloading unofficial wheels on Windows. Development/testing deps were also mixed into[project.optional-dependencies], which is meant for end-users.What do these changes do
[dependency-groups]inpyproject.tomlcovering all test suites (test-core,test-compact,test-extra,test-noauto-{torch,tensorflow,onnx,cython,network},test-corpus,test-full) plusdevanddocspyicuwithpyicu-wheelsin all test groups — pre-built wheels for all platforms, no compilation neededcompact,extra,noauto-*,full,dev,docsfrom[project.optional-dependencies]; feature sets (icu,spell,wordnet, etc.) remain untouchedpip install --group <name>brew install icu4cand Windows unofficial-wheel-download steps fromunittest.ymlWhat was wrong
[project.optional-dependencies]grouped both end-user feature sets and test/dev tooling together. Testing withpyicurequired platform-specific ICU compilation or unofficial binary sources, making local setup on macOS/Windows unnecessarily difficult.How this fixes it
PEP 735
[dependency-groups]cleanly separates dev/test deps from the distributed package metadata. Substitutingpyicu-wheels(Init7's pre-built distribution, for testing only — distribution deps still declarepyicu) eliminates all platform-specific ICU setup steps in CI and locally.Your checklist for this pull request
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.